test, doc: refer to the correct variable names in p2p_invalid_tx.py#22797
Merged
fanquake merged 1 commit intobitcoin:masterfrom Aug 26, 2021
Merged
test, doc: refer to the correct variable names in p2p_invalid_tx.py#22797fanquake merged 1 commit intobitcoin:masterfrom
fanquake merged 1 commit intobitcoin:masterfrom
Conversation
jonatack
reviewed
Aug 25, 2021
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK, would suggest naming the PR and commit something like test, doc: refer to the correct variable names in p2p_invalid_tx.py
aitorjs
changed the title
Contributor
|
Concept ACK Thanks, and welcome as a new contributor! |
kristapsk
approved these changes
Aug 25, 2021
theStack
approved these changes
Aug 25, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 28, 2021
…n p2p_invalid_tx.py 0d9fdd3 test, doc: refer to the correct variable names in p2p_invalid_tx.py (aitorjs) Pull request description: _tx_orphan_no_fee_ and _tx_orphan_invalid_ don't exist as transactions. Have been replaced by _tx_orphan_2_no_fee_ and _tx_orphan_2_invalid_ respectively. **Motivation**: Comments are more accurate and easy understandable under the tests context (I think). ACKs for top commit: kristapsk: utACK 0d9fdd3 theStack: ACK 0d9fdd3 📃 Tree-SHA512: a4cafd931e51fe2a67085e10e9c61178c864c14982664d112b76327e040af08cd1de04eca4a8ae980fad57ba7078017ce02fc60e7658f38380e8172c2ae28b77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tx_orphan_no_fee and tx_orphan_invalid don't exist as transactions.
Have been replaced by tx_orphan_2_no_fee and tx_orphan_2_invalid respectively.
Motivation: Comments are more accurate and easy understandable under the tests context (I think).