test: Check that non-signaling BIP125 tx can be replaced via parent#22809
Merged
fanquake merged 1 commit intobitcoin:masterfrom Sep 2, 2021
Merged
test: Check that non-signaling BIP125 tx can be replaced via parent#22809fanquake merged 1 commit intobitcoin:masterfrom
fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
Tested ACK |
mjdietzx
reviewed
Aug 30, 2021
Contributor
mjdietzx
left a comment
mjdietzx
left a comment
There was a problem hiding this comment.
ACK 222273adcc6b56da89b937ed0530487c4f7644b2
maflcko
force-pushed
the
2108-testTxReplace
branch
from
222273a to
fa2e9de
Compare
Member
Author
|
Good point. Added assertion |
Contributor
|
reACK fa2e9de |
Member
|
ACK fa2e9de |
Contributor
|
Tested ACK fa2e9de |
darosior
reviewed
Sep 2, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 2, 2021
…replaced via parent fa2e9de test: Check that non-signaling BIP125 tx can be replaced via parent (MarcoFalke) Pull request description: While `optout_child_tx` in the `test_no_inherited_signaling` test is reported as "bip125-replaceable", it is not *directly* replaceable. For example by bumping the fee of `optout_child_tx`. However, it is still replaceable *indirectly* via it's BIP-125 signalling parent. Clarify this by extending the test. ACKs for top commit: mjdietzx: Tested ACK fa2e9de josibake: ACK bitcoin@fa2e9de Tree-SHA512: b3608beae743dcb6152df4d2cfe1c0af6b4404ba3837f73e1d1431bd7c637f0c7fab0379aaab2218d5cd63e71070a079c0595ec031056058e8d3c933c2bae0a9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
optout_child_txin thetest_no_inherited_signalingtest is reported as "bip125-replaceable", it is not directly replaceable. For example by bumping the fee ofoptout_child_tx. However, it is still replaceable indirectly via it's BIP-125 signalling parent.Clarify this by extending the test.