build: Drop 32-bit build configurations for MSVC#22908
Merged
fanquake merged 2 commits intobitcoin:masterfrom Sep 11, 2021
Merged
build: Drop 32-bit build configurations for MSVC#22908fanquake merged 2 commits intobitcoin:masterfrom
fanquake merged 2 commits intobitcoin:masterfrom
Conversation
Member
Author
|
cc @sipsorcery |
Contributor
|
Concept ACK Somewhat related:
|
hebasto
force-pushed
the
210907-win32
branch
from
8c49dc2 to
57b3c5b
Compare
Member
Author
|
Rebased 8c49dc2 -> 57b3c5b (pr22908.01 -> pr22908.02) on top of the recent changes in CI. |
Member
|
Concept ACK. There is no point in supporting this configuration, I'm sure it's wildly under-tested. 32-bit x86 is a museum architecture by now, and accidentally using a 32-bit build on 64-bit hardware will result in lousy performance. |
Member
|
Concept ACK - haven't / wont test though. |
sipsorcery
approved these changes
Sep 10, 2021
Contributor
|
tACK 57b3c5b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 32-bit application for Windows in 2021 looks outdated. I'm pretty sure no one is going to run Bitcoin Core v23.0 on 32-bit Windows.
Also see #15939.