cc @vasild

Just out of curiosity - what drove you to do this change? Did you use some tool which suggested these changes?

It is somewhat difficult to asses whether removing #include <asysheader> from foo.cpp is justified - how to check that foo.cpp is not using any of the functions from that header?

I see why <codecvt> was moved from netbase.cpp to util/sock.cpp - the windows-only variant of NetworkErrorString() is using std::codecvt_utf8_utf16 and that function was moved from netbase.cpp to util/sock.cpp (but the header was not moved).

Why remove <cwchar> from util/sock.cpp? Looks like in order to confirm this change is legit one has to verify that none of the symbols from https://en.cppreference.com/w/cpp/header/cwchar are used in util/sock.cpp. Is there an easy way to do that?

Same for making <locale> windows-only. How to check that non-windows code is not using any of its symbols?

@vasild

Just out of curiosity - what drove you to do this change?

Reading dec9b5e commit while working on #20744.

Did you use some tool which suggested these changes?

No. The added code is short enough to manually verify need of #include <cwchar> and #include <locale>.

Why remove <cwchar> from util/sock.cpp?

Why was it added in dec9b5e? I see no reason for that.

Same for making <locale> windows-only. How to check that non-windows code is not using any of its symbols?

Same. I see no reason to #include <locale> for non-Windows platforms in dec9b5e.

Is it time to integrate https://include-what-you-use.org/ into the project?

#15442

Guix builds

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

This was merged, but not marked as merged by GitHub.