test: Replace MiniWallet scan_blocks with rescan_utxos by maflcko · Pull Request #23017 · bitcoin/bitcoin

maflcko · 2021-09-17T13:24:15Z

This avoids having to fiddle with the start and num parameters and instead use the scantxoutset RPC functionality via rescan_utxos.

theStack · 2021-09-17T14:36:06Z

Concept ACK

DrahtBot · 2021-09-18T01:53:42Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#22867 (test: Extend test coverage of BIP125 and document confusing/inconsistent behavior by mjdietzx)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

theStack

ACK fa1b53f2d0532bbfa7982adfecaf84cdb59c8461 🍵

test/functional/mempool_spend_coinbase.py

theStack

re-ACK fa7e3f1

Shubhankar-Gambhir · 2021-09-20T20:45:59Z

ACK fa7e3f1, all tests were succesfull

feature_rbf.py

2021-09-20T20:29:57.177000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_6g5k6jja
2021-09-20T20:30:17.444000Z TestFramework (INFO): Running test simple doublespend...
2021-09-20T20:30:17.526000Z TestFramework (INFO): Running test doublespend chain...
2021-09-20T20:30:18.062000Z TestFramework (INFO): Running test doublespend tree...
2021-09-20T20:30:21.464000Z TestFramework (INFO): Running test replacement feeperkb...
2021-09-20T20:30:22.338000Z TestFramework (INFO): Running test spends of conflicting outputs...
2021-09-20T20:30:24.562000Z TestFramework (INFO): Running test new unconfirmed inputs...
2021-09-20T20:30:25.733000Z TestFramework (INFO): Running test too many replacements...
2021-09-20T20:30:27.604000Z TestFramework (INFO): Running test opt-in...
2021-09-20T20:30:28.917000Z TestFramework (INFO): Running test RPC...
2021-09-20T20:30:35.362000Z TestFramework (INFO): Running test prioritised transactions...
2021-09-20T20:30:50.683000Z TestFramework (INFO): Running test no inherited signaling...
2021-09-20T20:30:50.716000Z TestFramework (INFO): Check that the child tx can still be replaced (via a tx that also replaces the parent)
2021-09-20T20:30:50.722000Z TestFramework (INFO): Running test replacement relay fee...
2021-09-20T20:30:50.726000Z TestFramework (INFO): Passed
2021-09-20T20:30:50.777000Z TestFramework (INFO): Stopping nodes
2021-09-20T20:30:58.614000Z TestFramework (INFO): Cleaning up /tmp/bitcoin_func_test_6g5k6jja on exit
2021-09-20T20:30:58.614000Z TestFramework (INFO): Tests successful

mempool_reorg.py

2021-09-20T20:11:58.347000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_raz1f_0t
2021-09-20T20:12:16.412000Z TestFramework (INFO): Add 4 coinbase utxos to the miniwallet
2021-09-20T20:12:19.429000Z TestFramework (INFO): Create three transactions spending from coinbase utxos: spend_1, spend_2, spend_3
2021-09-20T20:12:19.438000Z TestFramework (INFO): Create another transaction which is time-locked to two blocks in the future
2021-09-20T20:12:19.442000Z TestFramework (INFO): Check that the time-locked transaction is too immature to spend
2021-09-20T20:12:19.655000Z TestFramework (INFO): Broadcast and mine spend_2 and spend_3
2021-09-20T20:12:19.668000Z TestFramework (INFO): Generate a block
2021-09-20T20:12:19.674000Z TestFramework (INFO): Check that time-locked transaction is still too immature to spend
2021-09-20T20:12:19.676000Z TestFramework (INFO): Create spend_2_1 and spend_3_1
2021-09-20T20:12:19.682000Z TestFramework (INFO): Broadcast and mine spend_3_1
2021-09-20T20:12:19.685000Z TestFramework (INFO): Generate a block
2021-09-20T20:12:19.700000Z TestFramework (INFO): The time-locked transaction can now be spent
2021-09-20T20:12:19.702000Z TestFramework (INFO): Add spend_1 and spend_2_1 to the mempool
2021-09-20T20:12:20.722000Z TestFramework (INFO): invalidate the last block
2021-09-20T20:12:20.729000Z TestFramework (INFO): The time-locked transaction is now too immature and has been removed from the mempool
2021-09-20T20:12:20.730000Z TestFramework (INFO): spend_3_1 has been re-orged out of the chain and is back in the mempool
2021-09-20T20:12:20.732000Z TestFramework (INFO): Use invalidateblock to re-org back and make all those coinbase spends immature/invalid
2021-09-20T20:12:20.768000Z TestFramework (INFO): Check that the mempool is empty
2021-09-20T20:12:20.826000Z TestFramework (INFO): Stopping nodes
2021-09-20T20:12:26.103000Z TestFramework (INFO): Cleaning up /tmp/bitcoin_func_test_raz1f_0t on exit
2021-09-20T20:12:26.104000Z TestFramework (INFO): Tests successful

mempool_spend_coinbase.py

2021-09-20T20:13:25.574000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_hxheqe3j
2021-09-20T20:13:29.098000Z TestFramework (INFO): Stopping nodes
2021-09-20T20:13:29.503000Z TestFramework (INFO): Cleaning up /tmp/bitcoin_func_test_hxheqe3j on exit
2021-09-20T20:13:29.504000Z TestFramework (INFO): Tests successful

rpc_blockchain.py

2021-09-20T20:15:13.694000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_atozw1v4
2021-09-20T20:15:20.477000Z TestFramework (INFO): Generate 200 blocks after the genesis block in ten-minute steps
2021-09-20T20:15:30.242000Z TestFramework (INFO): Test getblockchaininfo
2021-09-20T20:15:40.739000Z TestFramework (INFO): Test getchaintxstats
2021-09-20T20:15:40.925000Z TestFramework (INFO): Test gettxoutsetinfo works for blockchain with just the genesis block
2021-09-20T20:15:41.577000Z TestFramework (INFO): Test gettxoutsetinfo returns the same result after invalidate/reconsider block
2021-09-20T20:15:42.616000Z TestFramework (INFO): Test gettxoutsetinfo hash_type option
2021-09-20T20:15:43.059000Z TestFramework (INFO): Test getblockheader
2021-09-20T20:15:43.071000Z TestFramework (INFO): Test getdifficulty
2021-09-20T20:15:43.072000Z TestFramework (INFO): Test getnetworkhashps
2021-09-20T20:15:43.073000Z TestFramework (INFO): Test stopping at height
2021-09-20T20:15:47.561000Z TestFramework (INFO): Test waitforblockheight
2021-09-20T20:15:47.937000Z TestFramework (INFO): Test getblock with verbosity 1 doesn't include fee
2021-09-20T20:15:47.941000Z TestFramework (INFO): Test getblock with verbosity 2 includes expected fee
2021-09-20T20:15:47.945000Z TestFramework (INFO): Test getblock with verbosity 2 still works with pruned Undo data
2021-09-20T20:15:47.945000Z TestFramework (INFO): Test getblock with invalid verbosity type returns proper error message
2021-09-20T20:15:48.059000Z TestFramework (INFO): Stopping nodes
2021-09-20T20:15:49.418000Z TestFramework (INFO): Cleaning up /tmp/bitcoin_func_test_atozw1v4 on exit
2021-09-20T20:15:49.418000Z TestFramework (INFO): Tests successful

…_utxos

maflcko force-pushed the 2109-testMiniWalletCleanup branch from 57fe71b to fa1b53f Compare September 17, 2021 13:24

fanquake added the Tests label Sep 17, 2021

DrahtBot mentioned this pull request Sep 18, 2021

test: Extend test coverage of BIP125 and document confusing/inconsistent behavior #22867

Closed

theStack approved these changes Sep 19, 2021

View reviewed changes

test/functional/mempool_spend_coinbase.py Outdated Show resolved Hide resolved

test: Replace MiniWallet scan_blocks with rescan_utxos

fa7e3f1

maflcko force-pushed the 2109-testMiniWalletCleanup branch from fa1b53f to fa7e3f1 Compare September 20, 2021 06:31

theStack approved these changes Sep 20, 2021

View reviewed changes

Shubhankar-Gambhir approved these changes Sep 20, 2021

View reviewed changes

maflcko merged commit 89447a6 into bitcoin:master Sep 21, 2021

maflcko deleted the 2109-testMiniWalletCleanup branch September 21, 2021 07:29

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 21, 2021

Merge bitcoin#23017: test: Replace MiniWallet scan_blocks with rescan…

245e861

…_utxos

glozow mentioned this pull request Oct 29, 2021

rpc: deprecate top-level fee fields in getmempool RPCs #22689

Merged

bitcoin locked and limited conversation to collaborators Oct 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Replace MiniWallet scan_blocks with rescan_utxos#23017

test: Replace MiniWallet scan_blocks with rescan_utxos#23017
maflcko merged 1 commit intobitcoin:masterfrom
maflcko:2109-testMiniWalletCleanup

maflcko commented Sep 17, 2021

Uh oh!

theStack commented Sep 17, 2021

Uh oh!

DrahtBot commented Sep 18, 2021

Uh oh!

theStack left a comment

Uh oh!

Uh oh!

theStack left a comment

Uh oh!

Shubhankar-Gambhir commented Sep 20, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

maflcko commented Sep 17, 2021

Uh oh!

theStack commented Sep 17, 2021

Uh oh!

DrahtBot commented Sep 18, 2021

Conflicts

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

Shubhankar-Gambhir commented Sep 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Shubhankar-Gambhir commented Sep 20, 2021 •

edited

Loading