ci: Increase the dynamic port range to the maximum on native Windows#23089
Merged
maflcko merged 2 commits intobitcoin:masterfrom Sep 25, 2021
Merged
ci: Increase the dynamic port range to the maximum on native Windows#23089maflcko merged 2 commits intobitcoin:masterfrom
maflcko merged 2 commits intobitcoin:masterfrom
Conversation
This change should mitigate "OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted".
Member
|
concept ACK 097ac74 |
maflcko
reviewed
Sep 25, 2021
| # Increase the dynamic port range to the maximum allowed value to mitigate "OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted". | ||
| # See: https://docs.microsoft.com/en-us/biztalk/technical-guides/settings-that-can-be-modified-to-improve-network-performance | ||
| - netsh int ipv4 set dynamicport tcp start=1025 num=64511 | ||
| - netsh int ipv6 set dynamicport tcp start=1025 num=64511 |
Member
There was a problem hiding this comment.
does this mean they might collide with the p2p and rpc ports from [TEST_RUNNER_PORT_MIN, TEST_RUNNER_PORT_MIN + 2 * range] ([14000, 24000])?
Member
Author
There was a problem hiding this comment.
Yes, if an ephemeral port by accident belongs to that range a collision is possible. But this range limits only ports of P2P and RPC connections. Our test framework uses ports out of this range in the feature_bind_extra.py and feature_proxy.py. The former is skipped on Windows, but the latter still could be a source of port collisions.
Member
|
Maybe this allows to revert fab9899 some day? |
darosior
reviewed
Sep 25, 2021
Member
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
Concept ACK. Most of the latest PRs are currently failing CI because of this.
maflcko
pushed a commit
to bitcoin-core/gui
that referenced
this pull request
Sep 27, 2021
…roxy fad0227 test: Remove Windows workaround in authproxy (MarcoFalke) Pull request description: Might no longer be needed after bitcoin/bitcoin#23089 ACKs for top commit: hebasto: ACK fad0227, passed 3 consequential runs on my [personal CI](https://cirrus-ci.com/task/4897456077930496): Tree-SHA512: 3c408e068ad7590dc0e5922c0b4cd3bf927e22fe624b13b8ab38db848342d310c9c934f358638fd5234c7b5f10f95d3bddc676deb925dcbba54945e2e8229275
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 27, 2021
fad0227 test: Remove Windows workaround in authproxy (MarcoFalke) Pull request description: Might no longer be needed after bitcoin#23089 ACKs for top commit: hebasto: ACK fad0227, passed 3 consequential runs on my [personal CI](https://cirrus-ci.com/task/4897456077930496): Tree-SHA512: 3c408e068ad7590dc0e5922c0b4cd3bf927e22fe624b13b8ab38db848342d310c9c934f358638fd5234c7b5f10f95d3bddc676deb925dcbba54945e2e8229275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18548.
The solution suggested in #18548 (comment).
Also more functional tests added to the native Windows task.