Remove -rescan startup parameter#23123
Closed
meshcollider wants to merge 4 commits intobitcoin:masterfrom
meshcollider:202109_remove_rescan
Closed
Remove -rescan startup parameter#23123meshcollider wants to merge 4 commits intobitcoin:masterfrom meshcollider:202109_remove_rescan
-rescan startup parameter#23123meshcollider wants to merge 4 commits intobitcoin:masterfrom
meshcollider:202109_remove_rescan
Conversation
maflcko
reviewed
Sep 29, 2021
maflcko
approved these changes
Sep 29, 2021
maflcko
reviewed
Sep 29, 2021
maflcko
approved these changes
Sep 29, 2021
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
Approach ACK 256314b984a215fab0cf16b13a234ae002e987c4
Didn't review closely
Member
|
Concept ACK |
Member
|
utACK 256314b |
Member
|
Concept and code review ACK 256314b984a215fab0cf16b13a234ae002e987c4 |
achow101
reviewed
Sep 29, 2021
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Sep 29, 2021
Contributor
Author
|
Modified second commit to use |
Member
|
ACK dc3ec74 |
This was referenced Sep 30, 2021
Member
|
re-ACK dc3ec74 |
laanwj
added a commit
to bitcoin-core/gui
that referenced
this pull request
Sep 30, 2021
dc3ec74 Add rescan removal release note (Samuel Dobson) bccd1d9 Remove -rescan startup parameter (Samuel Dobson) f963b0f Corrupt wallet tx shouldn't trigger rescan of all wallets (Samuel Dobson) 6c00649 Remove outdated dummy wallet -salvagewallet arg (Samuel Dobson) Pull request description: Remove the `-rescan` startup parameter. Rescans can be run with the `rescanblockchain` RPC. Rescans are still done on wallet-load if needed due to corruption, for example. ACKs for top commit: achow101: ACK dc3ec74 laanwj: re-ACK dc3ec74 Tree-SHA512: 608360d0e7d73737fd3ef408b01b33d97a75eebccd70c6d1b47a32fecb99b9105b520b111b225beb10611c09aa840a2b6d2b6e6e54be5d0362829e757289de5c
ryanofsky
approved these changes
Sep 30, 2021
| LOAD_FAIL, | ||
| NEED_REWRITE | ||
| NEED_REWRITE, | ||
| RESCAN_REQUIRED |
Contributor
There was a problem hiding this comment.
In commit "Corrupt wallet tx shouldn't trigger rescan of all wallets" (f963b0f)
Minor: Might call this NEED_RESCAN to be consistent with NEED_REWRITE
Member
There was a problem hiding this comment.
I think this is a good suggestion to be more consistent. Maybe in a follow-up PR.
Contributor
Author
|
Merged here: 571bb94 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 1, 2021
fanquake
added a commit
that referenced
this pull request
Oct 1, 2021
8615507 scripted-diff: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN (Samuel Dobson) Pull request description: Suggested here as a trivial follow-up: #23123 (comment) Makes RESCAN_REQUIRED consistent with NEED_REWRITE ACKs for top commit: achow101: ACK 8615507 jonatack: ACK 8615507 Tree-SHA512: 82d057c45e192cd6dd8a47675b52699e6cbc82272609a971e6e5d6796aad14a941a70e40d3913dbb611f79c8eadff8030c60ea6f203f2edc3720c0e78c166b97
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 1, 2021
…ED_RESCAN 8615507 scripted-diff: rename DBErrors::RESCAN_REQUIRED to NEED_RESCAN (Samuel Dobson) Pull request description: Suggested here as a trivial follow-up: bitcoin#23123 (comment) Makes RESCAN_REQUIRED consistent with NEED_REWRITE ACKs for top commit: achow101: ACK 8615507 jonatack: ACK 8615507 Tree-SHA512: 82d057c45e192cd6dd8a47675b52699e6cbc82272609a971e6e5d6796aad14a941a70e40d3913dbb611f79c8eadff8030c60ea6f203f2edc3720c0e78c166b97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
-rescanstartup parameter.Rescans can be run with the
rescanblockchainRPC.Rescans are still done on wallet-load if needed due to corruption, for example.