tests: Use test framework utils where possible by vincenzopalazzo · Pull Request #23127 · bitcoin/bitcoin

vincenzopalazzo · 2021-09-29T07:36:37Z

This PR removes when it is possible the native python assert, and use the test utils function, like assert_equal, assert_greater_than, assert_greater_than_or_equal.

Update

In addition, this PR includes a new operator assert_not_equal, which IMO it is useful to test other conditions and add the error message as a parameter of the function to give more flexibility.

Fixes #23119

Edit laanwj: removed HTML comment from post

test/functional/feature_backwards_compatibility.py

meshcollider · 2021-09-29T10:06:26Z

Thanks for contributing and helping out @vincenzopalazzo!

brunoerg · 2021-09-29T11:05:21Z

Concept ACK

brunoerg · 2021-09-29T11:47:50Z

Will it be created new PRs to update other tests or should we concentrate all the changes here?

vincenzopalazzo · 2021-09-29T11:54:53Z

Will it be created new PRs to update other tests or should we concentrate all the changes here?

The plan is to divide the work into small chunks to make the price of PR review easy and fast.

brunoerg · 2021-09-29T12:04:37Z

Will it be created new PRs to update other tests or should we concentrate all the changes here?

The plan is to divide the work into small chunks to make the price of PR review easy and fast.

Cool, thanks!

brunoerg · 2021-09-29T12:22:01Z

I just created #23135 to help on it

vincenzopalazzo · 2021-09-29T12:48:53Z

I just created #23135 to help on it

Thanks, the important think it that we don't make the double work :-)

DrahtBot · 2021-09-29T17:29:13Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#25732 (tests: Use test utils each time that it is possible by vincenzopalazzo)
#25291 (test: Refactor rpc_fundrawtransaction.py by akankshakashyap)
#23502 (wallet: Avoid underpaying transaction fees when signing taproot spends by achow101)
#20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)
#17794 (test: Use assert_greater_than_or_equal helper method to aid debugging. by jbampton)
#16545 (refactor: Implement missing error checking for ArgsManager flags by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

michaelfolkson · 2021-10-04T10:02:53Z

Concept ACK

I think generally splitting across multiple pull requests works best for the monster sub-projects (AssumeUTXO, deglobalizing ChainstateManager, Process Separation etc).

In this case splitting across multiple commits within the same PR would probably have been sufficient to make it easily reviewable but not a big deal and if it encourages multiple contributors to self-organize around completing it then that's great.

test/functional/test_framework/util.py

vincenzopalazzo · 2021-10-05T09:41:40Z

Thanks @michaelfolkson,

In this case splitting across multiple commits within the same PR would probably have been sufficient to make it easily reviewable but not a big deal and if it encourages multiple contributors to self-organize around completing it then that's great.

It sounds great to me, I will go with this solution. Thansk!

Signed-off-by: Vincenzo Palazzo <[email protected]>

Signed-off-by: Vincenzo Palazzo <[email protected]> # Title: Signed-off-by: Vincenzo Palazzo <[email protected]>

Signed-off-by: Vincenzo Palazzo <[email protected]>

fanquake · 2022-10-03T13:19:33Z

@vincenzopalazzo Given #25732, did you want to leave this one open as well, or close for now?

vincenzopalazzo · 2022-10-03T13:53:03Z

better close this and hope that someone will finish the job :)

fanquake added the Tests label Sep 29, 2021

meshcollider reviewed Sep 29, 2021

View reviewed changes

test/functional/feature_backwards_compatibility.py Outdated Show resolved Hide resolved

vincenzopalazzo force-pushed the tests/use_testutils branch from d1c6861 to ab7b997 Compare September 29, 2021 10:12

maflcko changed the title ~~tests: Use test utils each time that it is possible~~ tests: Use assert_equal* utils where possible Sep 29, 2021

vincenzopalazzo force-pushed the tests/use_testutils branch 2 times, most recently from 97ba20f to 580754c Compare September 29, 2021 15:19

vincenzopalazzo requested a review from meshcollider September 29, 2021 15:20

vincenzopalazzo force-pushed the tests/use_testutils branch from 580754c to 0ff961c Compare September 29, 2021 19:48

DrahtBot mentioned this pull request Sep 30, 2021

test: add v0.20.1, v0.21.0 and v22.0 to backwards compatibility test #19013

Merged

vincenzopalazzo force-pushed the tests/use_testutils branch 3 times, most recently from 62112a2 to 80c593f Compare October 3, 2021 09:03

kiminuo reviewed Oct 4, 2021

View reviewed changes

test/functional/test_framework/util.py Outdated Show resolved Hide resolved

vincenzopalazzo force-pushed the tests/use_testutils branch 2 times, most recently from a83d95b to 6fbb7e1 Compare October 5, 2021 09:40

vincenzopalazzo force-pushed the tests/use_testutils branch 2 times, most recently from ac5796a to 5352392 Compare October 5, 2021 10:36

brunoerg mentioned this pull request Oct 5, 2021

test: Use asset_equal utils where possible in feature_nulldummy #23135

Closed

vincenzopalazzo mentioned this pull request Oct 8, 2021

test: replace bare asserts with assertion helpers (assert_equal() etc.) #23119

Open

vincenzopalazzo force-pushed the tests/use_testutils branch from 5352392 to fab2ba3 Compare October 10, 2021 14:01

vincenzopalazzo added 25 commits July 28, 2022 23:32

feature_taproot.py: Use the err_msg introduced in the assert framework.

c5e4b28

Signed-off-by: Vincenzo Palazzo <[email protected]>

interface_zmq.py: Refactoring message parameter with err_msg

39dc774

Signed-off-by: Vincenzo Palazzo <[email protected]>

p2p_compactblocks.py: Using test framework

f968cfc

Signed-off-by: Vincenzo Palazzo <[email protected]>

p2p_getaddr_caching.py: Using test framework utils

de2bf99

Signed-off-by: Vincenzo Palazzo <[email protected]>

p2p_disconnect_ban.py: Use test framework

59bcf80

Signed-off-by: Vincenzo Palazzo <[email protected]>

p2p_invalid_messages.py: Use test framwork

451785d

Signed-off-by: Vincenzo Palazzo <[email protected]>

p2p_segwit.py: Including Test Framework

59e5b11

Signed-off-by: Vincenzo Palazzo <[email protected]>

p2p_tx_download.py: Use test framework.

5b8eb0a

Signed-off-by: Vincenzo Palazzo <[email protected]> # Title: Signed-off-by: Vincenzo Palazzo <[email protected]>

rpc_createmultisig.py: Use test framework

0f1f81d

Signed-off-by: Vincenzo Palazzo <[email protected]>

rpc_fundrawtransaction.py: Use test framework

435a8d6

Signed-off-by: Vincenzo Palazzo <[email protected]>

rpc_help.py: Use test framework

f02998f

Signed-off-by: Vincenzo Palazzo <[email protected]>

rpc_net.py: Using test frameowork

cf9df57

Signed-off-by: Vincenzo Palazzo <[email protected]>

tool_wallet.py: Using test framework

ca60e88

Signed-off-by: Vincenzo Palazzo <[email protected]>

wallet_address_types.py: using test framework

3f585d2

Signed-off-by: Vincenzo Palazzo <[email protected]>

wallet_disable.py: Use test framework

92769d0

Signed-off-by: Vincenzo Palazzo <[email protected]>

wallet_dump.py: Use test framework

1d4e9c4

Signed-off-by: Vincenzo Palazzo <[email protected]>

wallet_keypool.py: Use test framework

d2bfd3d

Signed-off-by: Vincenzo Palazzo <[email protected]>

wallet_listdescriptors.py: Use test framework

a85b6bc

Signed-off-by: Vincenzo Palazzo <[email protected]>

wallet_listsinceblock.py: Use test framework

75a122e

Signed-off-by: Vincenzo Palazzo <[email protected]>

wallet_listtransactions.py: Use test framework

b0d26d5

Signed-off-by: Vincenzo Palazzo <[email protected]>

wallet_txn_doublespend.py: Use test framwork

1131437

Signed-off-by: Vincenzo Palazzo <[email protected]>

tests: fixed import order and improve python style

9150da4

Signed-off-by: Vincenzo Palazzo <[email protected]>

test_framework: improve error messages

6229a1b

Signed-off-by: Vincenzo Palazzo <[email protected]>

interface_zmq.py: fixed unexpected indent introduced by rebase

e5a6a54

Signed-off-by: Vincenzo Palazzo <[email protected]>

fixed monkey rebase error

62ed9ff

Signed-off-by: Vincenzo Palazzo <[email protected]>

vincenzopalazzo mentioned this pull request Jul 28, 2022

tests: Use test utils each time that it is possible #25732

Closed

DrahtBot mentioned this pull request Sep 28, 2022

rpc, wallet: use the same next_index key in listdescriptors and importdescriptors #26194

Merged

jarolrod mentioned this pull request Oct 3, 2022

rpc: Return block hash & height in getbalances, gettransaction and getwalletinfo #26094

Merged

Conversation

vincenzopalazzo commented Sep 29, 2021 • edited by laanwj Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update

Uh oh!

Uh oh!

meshcollider commented Sep 29, 2021

Uh oh!

brunoerg commented Sep 29, 2021

Uh oh!

brunoerg commented Sep 29, 2021

Uh oh!

vincenzopalazzo commented Sep 29, 2021

Uh oh!

brunoerg commented Sep 29, 2021

Uh oh!

brunoerg commented Sep 29, 2021

Uh oh!

vincenzopalazzo commented Sep 29, 2021

Uh oh!

DrahtBot commented Sep 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

michaelfolkson commented Oct 4, 2021

Uh oh!

Uh oh!

vincenzopalazzo commented Oct 5, 2021

Uh oh!

fanquake commented Oct 3, 2022

Uh oh!

vincenzopalazzo commented Oct 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

vincenzopalazzo commented Sep 29, 2021 •

edited by laanwj

Loading

DrahtBot commented Sep 29, 2021 •

edited

Loading