test: Use asset_equal utils where possible in feature_nulldummy#23135
Closed
brunoerg wants to merge 1 commit intobitcoin:masterfrom
Closed
test: Use asset_equal utils where possible in feature_nulldummy#23135brunoerg wants to merge 1 commit intobitcoin:masterfrom
brunoerg wants to merge 1 commit intobitcoin:masterfrom
Conversation
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
NIT
I like to go next with the following idea #23127 (comment), put the work in different PR could be confusion on what it is done and whatnot.
Contributor
Author
I totally agree! Do you want me to close this PR? |
|
I included this change in the #23127. Sorry for the confusion, it is my fault. |
Contributor
Author
|
No problem, going to close it and review/test that PR! Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #23119