refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization#23199
Merged
fanquake merged 1 commit intobitcoin:masterfrom Oct 11, 2021
Conversation
Member
|
utACK 7fc487a |
Contributor
|
Concept ACK |
Member
|
Code review ACK 7fc487a |
theStack
deleted the
202110-refactor-use_be32_helpers_for_bip32_nchild
branch
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 11, 2021
…32 nChild (de)serialization 7fc487a refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (Sebastian Falbesoner) Pull request description: This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers `ReadBE32`/`WriteBE32`. Note that those were first introduced in bitcoin#4100, almost one year _after_ the BIP32 derivation implementation has been merged (bitcoin#2829, eb2c999). ACKs for top commit: sipa: utACK 7fc487a laanwj: Code review ACK 7fc487a Tree-SHA512: bbe3e411fb0429fa74c8a5705a91f4d6ed704dac9d6623ecb633563f22acf8e21f3189a16f1d0cf1aeedfc56a5b695df54ae51e9577e34eb6d7dc335de2da6de
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 13, 2022
…32 nChild (de)serialization 7fc487a refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (Sebastian Falbesoner) Pull request description: This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers `ReadBE32`/`WriteBE32`. Note that those were first introduced in dashpay#4100, almost one year _after_ the BIP32 derivation implementation has been merged (dashpay#2829, eb2c999). ACKs for top commit: sipa: utACK 7fc487a laanwj: Code review ACK 7fc487a Tree-SHA512: bbe3e411fb0429fa74c8a5705a91f4d6ed704dac9d6623ecb633563f22acf8e21f3189a16f1d0cf1aeedfc56a5b695df54ae51e9577e34eb6d7dc335de2da6de
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers
ReadBE32/WriteBE32. Note that those were first introduced in #4100, almost one year after the BIP32 derivation implementation has been merged (#2829, eb2c999).