doc: Fix outdated comments referring to ::ChainActive()#23258
Merged
fanquake merged 1 commit intobitcoin:masterfrom Oct 20, 2021
meshcollider:202110_outdated_chainstate_comments
Merged
doc: Fix outdated comments referring to ::ChainActive()#23258fanquake merged 1 commit intobitcoin:masterfrom meshcollider:202110_outdated_chainstate_comments
fanquake merged 1 commit intobitcoin:masterfrom
meshcollider:202110_outdated_chainstate_comments
Conversation
Contributor
|
ACK a0efe52 Thanks @meshcollider! |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 20, 2021
…ctive() a0efe52 Fix outdated comments referring to ::ChainActive() (Samuel Dobson) Pull request description: After bitcoin#21866 there are a few outdated comments referring to `::ChainActive()`, which should instead refer to `ChainstateManager::ActiveChain()`. ACKs for top commit: jamesob: ACK bitcoin@a0efe52 Tree-SHA512: 80da19c105ed29ac247e6df4c8e916c3bf3f37230b63f07302114eef9c115add673e9649f0bbe237295be0c6da7b1030b5b93e14daf6768f17ce5de7cf2c9ff2
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 15, 2022
…lizeBlock Summary: This removes the last occurences of `::Chain(State)Active` in the code after D11704, D11742 and D11744 are landed. There are some remaining occurences in comments, which are removed in a later backport ([[bitcoin/bitcoin#23258 | core#23258]]) I checked in the codebase that these methods are only called on the active chainstate. It does not make much sense to finalize blocks in a chain base on the state of some other chain anyway. Test Plan: Before running the tests, add the following line in both modified methods: `assert(std::addressof(m_chain) == std::addressof(::ChainActive()));` `ninja all check-all` Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D11748
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 15, 2022
Summary: Remove also a comment about g_chainstate. The additional `::ChainActive` comment removed in validation.cpp was missed in a backport in D1972. This is a backport of [[bitcoin/bitcoin#23258 | core#23258]] Test Plan: ``` grep -r "::Chain\w*A" ../src/ grep -r "g_chainman" ../src/ ``` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D11755
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #21866 there are a few outdated comments referring to
::ChainActive(), which should instead refer toChainstateManager::ActiveChain().