Skip to content

fuzz: Descriptor wallet#23334

Merged
maflcko merged 4 commits intobitcoin:masterfrom
maflcko:2110-fuzzWall
Nov 5, 2021
Merged

fuzz: Descriptor wallet#23334
maflcko merged 4 commits intobitcoin:masterfrom
maflcko:2110-fuzzWall

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Oct 21, 2021

Initial sketch to fuzz descriptor wallets. Can be improved in the future.

@mjdietzx
Copy link
Contributor

mjdietzx commented Oct 27, 2021

Looks great so far. I was curious about the file name src/wallet/test/fuzz/notifications.cpp (specifically the notifications part), could you explain the logic behind that for my understanding?

Also, can you point me to where this test runs in the CI logs so I can take a look, haven't been able to find it yet?

@maflcko
Copy link
Member Author

maflcko commented Oct 28, 2021

(specifically the notifications part)

This test is using the blockConnected/blockDisconnected interface of the wallet. Those are referred to as "chain notifications" sometimes.

Also, can you point me to where this test runs in the CI logs so I can take a look, haven't been able to find it yet?

Ooops, it is not built by CI. Will fix.

@maflcko
Copy link
Member Author

maflcko commented Oct 28, 2021

Ok fixed, it is "running" here now: https://cirrus-ci.com/task/4611029003927552?logs=ci#L1359

@mjdietzx
Copy link
Contributor

mjdietzx commented Oct 28, 2021

Code review ACK 1111516

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 28, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@DrahtBot DrahtBot mentioned this pull request Oct 29, 2021
Merged
@maflcko maflcko merged commit 77a2f5d into bitcoin:master Nov 5, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 5, 2021
Merge bitcoin#23334: fuzz: Descriptor wallet
41d1c2e
@maflcko maflcko deleted the 2110-fuzzWall branch November 5, 2021 16:29
hebasto
hebasto reviewed Nov 7, 2021
View reviewed changes
src/wallet/test/fuzz/notifications.cpp
using Coins = std::set<std::tuple<CAmount, COutPoint>>;
std::vector<std::tuple<Coins, CBlock>> chain;
{
// Add the inital entry
Copy link
Member

@hebasto hebasto Nov 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: inital ==> initial

@bitcoin bitcoin locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto left review comments

Assignees

No one assigned

Labels

Tests Wallet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maflcko @mjdietzx @DrahtBot @hebasto @Madmade77