build: Drop unneeded dependencies for bitcoin-wallet tool#23345
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 15, 2021
Merged
build: Drop unneeded dependencies for bitcoin-wallet tool#23345laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Concept ACK |
luke-jr
reviewed
Oct 29, 2021
Member
luke-jr
left a comment
luke-jr
left a comment
There was a problem hiding this comment.
Doesn't this also need configure changes to allow building it without unnecessary deps? (Possibly could be a followup PR, but fits here)
hebasto
force-pushed
the
211024-bw-deps
branch
from
1d96788 to
347774b
Compare
Member
Author
|
Updated 1d96788 -> 347774b (pr23345.01 -> pr23345.02, diff):
|
Member
Author
Guix builds: |
This was referenced Nov 2, 2021
Contributor
|
contributing GUIX hashes, mine match @hebasto |
luke-jr
reviewed
Nov 2, 2021
| fi | ||
|
|
||
| build_leveldb=yes | ||
| if test x$build_bitcoin_cli$build_bitcoin_tx$build_bitcoin_util$build_bitcoind$bitcoin_enable_qt$use_bench$use_tests = xnonononononono; then |
Member
There was a problem hiding this comment.
I guess we should only be checking bitcoind/bitcoin-qt here (the other tools don't need them either?), but perhaps that's safer left for a later PR...
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Nov 4, 2021
Github-Pull: bitcoin#23345 Rebased-From: 347774b
laanwj
reviewed
Nov 10, 2021
hebasto
force-pushed
the
211024-bw-deps
branch
from
347774b to
4fe7cf1
Compare
Member
Author
|
Updated 347774b -> 4fe7cf1 (pr23345.02 -> pr23345.03):
|
Member
Author
Guix builds: |
Member
|
Code review ACK 4fe7cf1 |
fanquake
added a commit
that referenced
this pull request
Oct 31, 2022
…P, NAT-PMP, or ZMQ 9886863 Bugfix: configure: bitcoin-{cli,tx,util} don't need UPnP, NAT-PMP, or ZMQ (Luke Dashjr) Pull request description: As with #23345, these other tools likewise don't use various deps. ACKs for top commit: achow101: ACK 9886863 Tree-SHA512: 4be056b8e0c9f69834229aa257187457de1bc34214d320b770834e21ecc1f0ca7aa7b9689fba525928947bfabbb461528795f709014fb9618b82f088fe64f271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bitcoin-walletis an offline tool, and its code does not depend on networking stuff (ZMQ, UPnP, NAT-PMP, and LIBBITCOIN_SERVER).Also
bitcoin-walletdoes not interacts with the chainstate, therefore dependency on LevelDB is not needed.