Revert "build: fix ASLR for bitcoin-cli on Windows"#23360
Closed
hebasto wants to merge 1 commit intobitcoin:masterfrom
Closed
Revert "build: fix ASLR for bitcoin-cli on Windows"#23360hebasto wants to merge 1 commit intobitcoin:masterfrom
hebasto wants to merge 1 commit intobitcoin:masterfrom
Conversation
This reverts commit 315a4d3.
Member
Author
Member
Author
Guix builds: |
Contributor
|
Ooooh this is good info. I'm wondering if the debian mingw-w64 binutils version will still produce binaries with broken ASLR? |
Member
Author
Do you mean |
Contributor
|
Yes, and perhaps stretch since that is supposedly still supported. |
Member
|
NACK. This just reduces security for anyone building with an older binutils. |
Member
Author
A Guix build still available for everyone who concerns about security 🐅
Closing. |
Member
|
You could change this PR to instead add a comment that this is solved in newer binutils (if possible, include version number) and the workaround can estensibly go at some point. But yes, probably not now yet. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found it possible to revert #18702 for the following reasons:
bitcoin-cli.exebinary passessecurity-check.pybitcoin-cli.exe(rebooted between screenshots):