test: move check_node_connections to util#23392
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 29, 2021
Merged
Conversation
brunoerg
force-pushed
the
2021-10-check-node-connections
branch
from
994dc1b to
5ce601c
Compare
brunoerg
force-pushed
the
2021-10-check-node-connections
branch
from
5ce601c to
ab9bfc8
Compare
maflcko
reviewed
Nov 18, 2021
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
I think all commits can be squashed into one to allow for easy --color-moved=dimmed-zebra.
brunoerg
force-pushed
the
2021-10-check-node-connections
branch
from
ab9bfc8 to
4e831f1
Compare
Contributor
Author
Done. |
brunoerg
force-pushed
the
2021-10-check-node-connections
branch
from
4e831f1 to
988024f
Compare
Member
|
Code review ACK 988024f |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 29, 2021
RandyMcMillan
pushed a commit
to RandyMcMillan/mempool-tab
that referenced
this pull request
Dec 23, 2021
61af443 test: add check_node_connections in util (brunoerg) Pull request description: This function (`check_node_connections`) exists in `feature_anchors.py` and `p2p_add_connections.py` and does the same thing in both, this PR moves this function to util to avoid repetition and facilitate maintenance. ACKs for top commit: laanwj: Code review ACK 61af443 Tree-SHA512: bf86c5659933539c72cb91ad587552b45c918be74d36fb429e78f3b954f01ed0855a85dd49aea35b432fbd18227c05eb3fec8b99c139c3509c39b19bccf6b7fd
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 3, 2022
Summary: ``` This function (check_node_connections) exists in feature_anchors.py and p2p_add_connections.py and does the same thing in both, this PR moves this function to util to avoid repetition and facilitate maintenance. ``` Backport of [[bitcoin/bitcoin#23392 | core#23392]] and [[bitcoin/bitcoin#23774 | core#23774]] (missing import fix). Depends on D10966. Ref T1696. Test Plan: ninja check-functional Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Maniphest Tasks: T1696 Differential Revision: https://reviews.bitcoinabc.org/D10967
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function (
check_node_connections) exists infeature_anchors.pyandp2p_add_connections.pyand does the same thing in both, this PR moves this function to util to avoid repetition and facilitate maintenance.