Closed
Conversation
added 2 commits
November 12, 2021 11:40
The wrong indentation breaks editor workflows. Can be reviewed with --ignore-all-space
brunoerg
approved these changes
Nov 12, 2021
shaavan
approved these changes
Nov 12, 2021
Contributor
|
Code review ACK 0000eda |
maflcko
pushed a commit
that referenced
this pull request
Nov 12, 2021
0000eda style: Use 4 spaces for indentation, not 5 (MarcoFalke) fab9264 test: Remove unused CDataStream copy (MarcoFalke) Pull request description: Fix two issues: * Remove unneeded code, which makes test harder to read and write * Fix wrong indentation, which breaks some editors ACKs for top commit: jnewbery: Code review ACK 0000eda brunoerg: cr/tACK 0000eda shaavan: ACK 0000eda Tree-SHA512: babec1dfb840bd11ec89ec3d0e2529f826f5775fc7625e987480fac5251f6a6cdcf9a1051c8364d6ca2f66ce9934dcb8447a8cf7376b3952920faf2afd02be99
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 12, 2021
0000eda style: Use 4 spaces for indentation, not 5 (MarcoFalke) fab9264 test: Remove unused CDataStream copy (MarcoFalke) Pull request description: Fix two issues: * Remove unneeded code, which makes test harder to read and write * Fix wrong indentation, which breaks some editors ACKs for top commit: jnewbery: Code review ACK 0000eda brunoerg: cr/tACK 0000eda shaavan: ACK 0000eda Tree-SHA512: babec1dfb840bd11ec89ec3d0e2529f826f5775fc7625e987480fac5251f6a6cdcf9a1051c8364d6ca2f66ce9934dcb8447a8cf7376b3952920faf2afd02be99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues: