test: Return the largest utxo in MiniWallet.get_utxo#23515
Merged
maflcko merged 1 commit intobitcoin:masterfrom Nov 15, 2021
Merged
test: Return the largest utxo in MiniWallet.get_utxo#23515maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Member
Author
|
Going to merge this, but maybe someone donates a post-merge ack some day? |
Member
theStack
reviewed
Nov 15, 2021
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Post-merge code-review ACK fa62207 🪐
Note that this changes the functionality of create_self_transfer slightly: before it would always sort the internal UTXOs first, now it would only do that if no utxo_to_spend is passed. I don't think this is a problem though -- actually it seems to be more logical to only sort if needed.
Also checked that only one (out of 7) instance of .get_utxo() calls without parameters are expecting to get the change output, which is tackled in rpc_txoutproof.py by passing the txid.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 16, 2021
…utxo fa62207 test: Return the largest utxo in MiniWallet.get_utxo (MarcoFalke) Pull request description: This is for consistency with the `send_self_transfer` method. Also, remove the feature that the change of the last transfer can be retrieved via `get_utxo`. This can trivially and clearer be achieved by simply passing the txid of the transfer. Also, this fixes the bug in `feature_txindex_compatibility` in current master after a silent merge conflict. Fixes bitcoin#23514 Top commit has no ACKs. Tree-SHA512: edd066d372aaa72b4e0fc7526f84931c8d1f6d14f53678cb7832bc8e3d211f44b90ec9c59b7d915ef24acc63a36e7d66c8d3b7598355bd490ac637ed3bcc3dff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for consistency with the
send_self_transfermethod.Also, remove the feature that the change of the last transfer can be retrieved via
get_utxo. This can trivially and clearer be achieved by simply passing the txid of the transfer.Also, this fixes the bug in
feature_txindex_compatibilityin current master after a silent merge conflict.Fixes #23514