doc: Pick better named args for MutableTransactionSignatureCreator#23525
Conversation
Argument names of "nInIn" are not helpful.
|
Concept ACK. |
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
ACK fa54a40
The variable names are now more understandable and follow snake_case naming convention, rather than camel case convention, which is in line with bitcoin’s naming convention.
Similarly, direct initialization (()) is replaced with direct list initialization ({}) for initializing member variables of the MutableTransactionSignatureCreator class.
I have checked for clang-formatting for the changes introduced, and I found no formatting issues either.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
…onSignatureCreator fa54a40 doc: Pick better named args for MutableTransactionSignatureCreator (MarcoFalke) Pull request description: Argument names of `nInIn` are not helpful. ACKs for top commit: shaavan: ACK fa54a40 achow101: ACK fa54a40 Tree-SHA512: 53a38588fdee07d7896a66339c1c2c2355638db95a95cad9844b60cd34e935bb726ab64d0c42dc414beb35375e56440f8a9cb3fbf5aec55c1eed066b7acad8c8
5 participants
Argument names of
nInInare not helpful.