scripted-diff: Use clang-tidy syntax for C++ named arguments#23545
Closed
maflcko wants to merge 2 commits intobitcoin:masterfrom
Closed
scripted-diff: Use clang-tidy syntax for C++ named arguments#23545maflcko wants to merge 2 commits intobitcoin:masterfrom
maflcko wants to merge 2 commits intobitcoin:masterfrom
Conversation
Member
Author
|
Let's see how many conflicts this has 😅 |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
changed the title
Contributor
|
Concept ACK. |
This was referenced Nov 19, 2021
This was referenced Dec 11, 2021
maflcko
force-pushed
the
2109-docNamedArgs
branch
2 times, most recently
from
0018aff to
4a76579
Compare
maflcko
force-pushed
the
2109-docNamedArgs
branch
from
4a76579 to
483fe29
Compare
This was referenced Jan 6, 2022
Closed
maflcko
force-pushed
the
2109-docNamedArgs
branch
from
483fe29 to
ca4d48f
Compare
Member
Author
Pretty sure those are bugs in current master and have nothing to do with this pull? Maybe create a separate issues or pull to fix those? |
maflcko
force-pushed
the
2109-docNamedArgs
branch
from
ca4d48f to
6cf7512
Compare
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
maflcko
force-pushed
the
2109-docNamedArgs
branch
from
6cf7512 to
f5a7fa0
Compare
added 2 commits
February 4, 2022 11:43
-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's_(\(|\{|, ?)\/\* ?([^=* ]+) ?\*\/ ?_\1/*\2=*/_g' $( git grep -l --extended-regexp ', ?\/\* ?[^=* ]+ ?\*\/' ./src )
# perl -0777 -pi -e 's:((\(|\{|,)(\n| )*)\/\* ?([^=* ]+) ?\*\/ ?:\1/*\4=*/:g' $( git ls-files ./src/ )
-END VERIFY SCRIPT-
maflcko
force-pushed
the
2109-docNamedArgs
branch
from
f5a7fa0 to
63971b4
Compare
Member
Author
|
Closing as up for grabs |
Member
Picked up in #24661. |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 4, 2022
…guments 37a16ff refactor: fix clang-tidy named args usage (fanquake) Pull request description: > Incorrect named args are source of bugs, like bitcoin#22979. > To allow them being checked by clang-tidy, use a format it can understand. Picks up bitcoin#23545, with some additional changes and some feedback addressed. With these changes invoking `./autogen.sh && ./configure CC=clang-12 CXX=clang++-12 && make clean && bear make -j9 && ( cd ./src/ && run-clang-tidy-12 -j9 )` no-longer results in named argument errors out of `clang-tidy`. Ultimately I think we should just add `clang-tidy-*` jobs to the CI and automate things away. ACKs for top commit: MarcoFalke: cr ACK 37a16ff Tree-SHA512: 9bfc0d006eb187755b4fdb0bd92cee9266fc0816be42065ef7dcd885b9020ff12e3cdd7ca3a831613a56a0206d448e690ee4e1fa37628fa2013860e17f416ff3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect named args are source of bugs, like #22979.
To allow them being checked by
clang-tidy, use a format it can understand.