Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones: If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
Author
|
Pushed a commit to avoid newly uncovered error: |
This was referenced Nov 23, 2021
theStack
reviewed
Nov 23, 2021
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Concept ACK
Would it make sense to use CNetMsgMaker(...)::Make(..., ...) helper here for crafting the version message? Also, two yocto-nits: could replace magic strings "version" and "verack" by NetMsgType::VERSION / NetMsgType::VERACK.
maflcko
force-pushed
the
2111-fuzzFillNode
branch
from
faf4d45 to
faaf33a
Compare
Member
Author
|
Thanks, done. |
Merged
added 3 commits
December 1, 2021 12:14
Also, pass ConnmanTestMsg& and PeerManager& (needed for later commits).
maflcko
force-pushed
the
2111-fuzzFillNode
branch
from
faaf33a to
fa19bab
Compare
Member
Author
|
cc @jnewbery |
Contributor
|
Strong concept ACK and light code review ACK fa19bab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
FillNodeis a bit clumsy because it directly modifies memory ofCNode. This gets in the way of moving that memory toPeer. Also, it isn't particularly consistent. See for example #21160 (comment) .Fix all issues by sending a
version/verackinFillNodeand let net_processing figure out the internal details.