[WIP] DRAFT NOMERGE Tidy up RPCTxSerializationFlags#23599
Closed
maflcko wants to merge 2 commits intobitcoin:masterfrom
Closed
[WIP] DRAFT NOMERGE Tidy up RPCTxSerializationFlags#23599maflcko wants to merge 2 commits intobitcoin:masterfrom
maflcko wants to merge 2 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Nov 27, 2021
Merged
Merged
maflcko
force-pushed
the
2111-txSerF
branch
2 times, most recently
from
fa7d8a1 to
faea028
Compare
1 task
This was referenced Mar 25, 2022
This was referenced Apr 15, 2022
maflcko
changed the title
This was referenced Jul 26, 2022
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
added 2 commits
September 13, 2022 18:51
Also, rename the function to clarify that it only concerns tx serialization flags.
maflcko
force-pushed
the
2111-txSerF
branch
from
043ffe0 to
ddca261
Compare
Contributor
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
1 similar comment
Contributor
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPCSerializationFlagshas several issues:gArgsglobal, blocking progress on Remove gArgs #21005Fix all issues in this pull.