test: fix feature_rbf.py --descriptors and add to test runner#23608
Merged
fanquake merged 2 commits intobitcoin:masterfrom Nov 28, 2021
Merged
Conversation
This fixes the functional test feature_rbf.py for descriptor wallets.
Contributor
|
ACK b79dbe8 |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
theStack
deleted the
202111-test-fix-feature_rbf-for-descriptor-wallets
branch
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 29, 2021
… to test runner b79dbe8 test: add feature_rbf.py --descriptors to test_runner.py (Sebastian Falbesoner) 166f8ec test: always rescan after importing private keys in `init_wallet` helper (Sebastian Falbesoner) Pull request description: The functional test feature_rbf.py currently fails on master branch, if descriptor wallets are used (argument `--descriptors`). This is due to the fact that in this case, a call to the helper `init_wallet` https://github.com/bitcoin/bitcoin/blob/111c3e06b35b7867f2e0f740e988f648ac6c325d/test/functional/test_framework/test_framework.py#L428-L434 creates a wallet without rescanning the blockchain; the test framework maps the importprivkey RPC calls to the importdescriptors RPC without rescanning by default (timestamp='now'). Fix this by always calling with `rescan=True`, which calls importdescriptors with timestamp=0. Also add `feature_rbf.py --descriptors` to the list of the test runner's calls. Fixes bitcoin#23563. ACKs for top commit: mjdietzx: ACK b79dbe8 Tree-SHA512: a3f3f7a4077066e3c910919d3b5e04bc6b580c1e0a06e9a2fc258950eaea5e59c0f805c8f00432aea722609f2f7e41eebfab653471b76729c5a316825a3d8c86
RandyMcMillan
pushed a commit
to RandyMcMillan/mempool-tab
that referenced
this pull request
Dec 23, 2021
… and add to test runner 0d56e1f test: add feature_rbf.py --descriptors to test_runner.py (Sebastian Falbesoner) ee89b09 test: always rescan after importing private keys in `init_wallet` helper (Sebastian Falbesoner) Pull request description: The functional test feature_rbf.py currently fails on master branch, if descriptor wallets are used (argument `--descriptors`). This is due to the fact that in this case, a call to the helper `init_wallet` https://github.com/bitcoin/bitcoin/blob/e475dd3b063f0badc2a0a4b036741d7e1d6f7f16/test/functional/test_framework/test_framework.py#L428-L434 creates a wallet without rescanning the blockchain; the test framework maps the importprivkey RPC calls to the importdescriptors RPC without rescanning by default (timestamp='now'). Fix this by always calling with `rescan=True`, which calls importdescriptors with timestamp=0. Also add `feature_rbf.py --descriptors` to the list of the test runner's calls. Fixes #23563. ACKs for top commit: mjdietzx: ACK 0d56e1f Tree-SHA512: a3f3f7a4077066e3c910919d3b5e04bc6b580c1e0a06e9a2fc258950eaea5e59c0f805c8f00432aea722609f2f7e41eebfab653471b76729c5a316825a3d8c86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functional test feature_rbf.py currently fails on master branch, if descriptor wallets are used (argument
--descriptors). This is due to the fact that in this case, a call to the helperinit_walletbitcoin/test/functional/test_framework/test_framework.py
Lines 428 to 434 in 111c3e0
creates a wallet without rescanning the blockchain; the test framework maps the importprivkey RPC calls to the importdescriptors RPC without rescanning by default (timestamp='now'). Fix this by always calling with
rescan=True, which calls importdescriptors with timestamp=0. Also addfeature_rbf.py --descriptorsto the list of the test runner's calls.Fixes #23563.