build: Fix cross compiling with DEBUG=1 for Windows#23612
Closed
hebasto wants to merge 1 commit intobitcoin:masterfrom
Closed
build: Fix cross compiling with DEBUG=1 for Windows#23612hebasto wants to merge 1 commit intobitcoin:masterfrom
hebasto wants to merge 1 commit intobitcoin:masterfrom
Conversation
Member
|
Cannot test this at the moment. I'm confused why |
Member
Author
It controls how the libtool will be configured by the following |
luke-jr
suggested changes
Nov 30, 2021
Member
luke-jr
left a comment
luke-jr
left a comment
There was a problem hiding this comment.
Concept NACK. This doesn't fix the build, just prevents it...
Member
|
I agree with Luke. It's hard to call this a fix when it's just ignoring what's broken. As-is, we'd also get an undocumented special casing in our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On master (200d97f) cross compiling for Windows with depends being built with
DEBUG=1is broken in two places:libbitcoinconsensus, see build: Cross-compiling libbitcoinconsensus for Windows fails with DEBUG=1 #19772libunivalue, see build: tighter Univalue integration, remove--with-system-univalue#22646 (comment)This PR workarounds both cases.
Closes #19772.
The previous attempt was #21344.