refactor: Post-"Chainstate loading sequence coalescence" fixups#23855
Merged
maflcko merged 4 commits intobitcoin:masterfrom Jan 6, 2022
Merged
refactor: Post-"Chainstate loading sequence coalescence" fixups#23855maflcko merged 4 commits intobitcoin:masterfrom
maflcko merged 4 commits intobitcoin:masterfrom
Conversation
maflcko
changed the title
maflcko
approved these changes
Jan 6, 2022
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
ACK e3544c8 🐸
Show signature
Signature:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK e3544c864e3e56867de25b8db7b012d58b378050 🐸
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjGQQv+Nvv1zRWaWXIrwOzSvImTCAa1zNaRxiEbDL+L0/tLzKviDRoeB8jVrcvO
ZBzC6LKD1eHBBOz54EVMoNAzh72pbJfSFzF6EmVm13r3ydhm8je5WXi8PGOUQUvv
zpNvakUUf3nM64fIlq2r+GXRHmP7RmcDXsoNC3d6X3u/I73Mva/sm+M2aljAb0MM
YLE2Mat6eWLBtw1wzAkn/GS8r3qxQmGfyuZQRgRn3PcsJZkDTE96wMCSZAuIYCNb
/z+SV4QtmbN6+xwCQ0tPwYA19hkBvLJWPhEaDR5kIiiDKlgAFJpsqRBeb25K1Uc+
/AYXD/YAW+S+tOXqjtNo46eoN9U/Iq/OQkaP/EEBT8xUnaqGBZZxFA/4ucbx/WYq
P5C1VZ47vd2Cp72ckcrCv+ynRicFvL9T175sT1zijFsUQp/wQSpIOKGZ7RUvo7gQ
pR+Qy2pts7DlVTWpfLu9l+kyiLu5IDf+livi/Ahy9WS+K1C4t0S3JZxOJ6BrLxfD
UMV5AEjK
=Ddan
-----END PGP SIGNATURE-----
| /*coins_db_in_memory=*/false, | ||
| /*shutdown_requested=*/ShutdownRequested, | ||
| /*coins_error_cb=*/[]() { | ||
| uiInterface.ThreadSafeMessageBox( |
Member
There was a problem hiding this comment.
unrelated: But I think this can just be InitError(...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 proposed fixups in discussions in #23280 which I have not implemented:
*Chainstatefunctions: init: Coalesce Chainstate loading sequence between {,non-}unittest codepaths #23280 (comment)VerifyChainstateinstead of a callback to get the time: init: Coalesce Chainstate loading sequence between {,non-}unittest codepaths #23280 (comment)VerifyDBcan take quite a while, and I don't want to impose that the function have to "run quickly" in order to have it be correct.If reviewers feel strongly about either of the two fixups listed above, please feel free to open a PR based on mine and I'll close this one!