WIP: net/p2p:rename command*/Command/* to message*/Message* #24143
WIP: net/p2p:rename command*/Command/* to message*/Message* #24143RandyMcMillan wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
After reviewing PR #24141 MESSAGE_SIZE better suggests the usage and scope of this variable. |
RandyMcMillan
changed the title
RandyMcMillan
force-pushed
the
1643068742-rename-COMMAND_SIZE-to-MESSAGE_SIZE
branch
from
696f7d4 to
a0b6c0b
Compare
RandyMcMillan
force-pushed
the
1643068742-rename-COMMAND_SIZE-to-MESSAGE_SIZE
branch
from
a0b6c0b to
1bcf1f0
Compare
RandyMcMillan
force-pushed
the
1643068742-rename-COMMAND_SIZE-to-MESSAGE_SIZE
branch
from
1bcf1f0 to
cdc7db7
Compare
RandyMcMillan
force-pushed
the
1643068742-rename-COMMAND_SIZE-to-MESSAGE_SIZE
branch
2 times, most recently
from
bccebe2 to
ec85970
Compare
RandyMcMillan
changed the title
RandyMcMillan
force-pushed
the
1643068742-rename-COMMAND_SIZE-to-MESSAGE_SIZE
branch
3 times, most recently
from
62160ef to
58cc189
Compare
RandyMcMillan
force-pushed
the
1643068742-rename-COMMAND_SIZE-to-MESSAGE_SIZE
branch
4 times, most recently
from
5c410a0 to
2711a02
Compare
-BEGIN VERIFY SCRIPT-
test gsed && SED=$(which gsed) && export SED || SED=$(which sed)
export SRC=src
function s { git grep -l "$1" $SRC | xargs $SED -i "s/$1/$2/g"; }
function doit1 {
s 'COMMAND_SIZE' 'MESSAGE_SIZE'
s 'command name' 'message name'
s 'pchCommand' 'pchMessage'
s 'pszCommand' 'pszMessage'
s 'IsCommandValid' 'IsMessageValid'
}
function doit2 {
s 'GetCommand' 'GetMessage'
}
export SRC=src && doit1
export SRC=src/net.h && doit1
export SRC=src/net.cpp && doit1
export SRC=src/protocol.h && doit1
export SRC=src/protocol.cpp && doit1
export SRC=src/test/fuzz/protocol.cpp && doit1
export SRC=src/test/fuzz/protocol.cpp && doit2
export SRC=src/test/fuzz/process_messages.cpp && doit1
export SRC=src/test/fuzz/process_messages.cpp && doit2
-END VERIFY SCRIPT-
RandyMcMillan
force-pushed
the
1643068742-rename-COMMAND_SIZE-to-MESSAGE_SIZE
branch
from
2711a02 to
34a1d3b
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
I do think "Message" is a better fit than "Command" conceptually. A P2P network doesn't have commands. |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
3 participants
-BEGIN VERIFY SCRIPT-
SED=$(which gsed)
export SED
echo $SED
export SRC=src
function s { git grep -l "$1" $SRC | xargs $SED -i "s/$1/$2/g"; }
function doit1 {
s 'COMMAND_SIZE' 'MESSAGE_SIZE'
s 'command name' 'message name'
s 'pchCommand' 'pchMessage'
s 'pszCommand' 'pszMessage'
}
function doit2 {
s 'GetCommand' 'GetMessage'
}
export SRC=src && doit1
export SRC=src/net.h && doit1
export SRC=src/net.cpp && doit1
export SRC=src/protocol.h && doit1
export SRC=src/protocol.cpp && doit1
export SRC=src/test/fuzz/protocol.cpp && doit1
export SRC=src/test/fuzz/protocol.cpp && doit2
export SRC=src/test/fuzz/process_messages.cpp && doit1
export SRC=src/test/fuzz/process_messages.cpp && doit2
-END VERIFY SCRIPT-