rpc/doc: describe using combo(privkey) to get checksum and then list …#24161
rpc/doc: describe using combo(privkey) to get checksum and then list …#24161kallewoof wants to merge 1 commit intobitcoin:masterfrom
Conversation
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
Concept 0 in favor of #24162
As explained by @kallewoof here, the private key is in WIF format, which has checksum included in it. This two-step behavior of first deriving the checksum and then the addresses is hence redundant.
So I think instead of providing documentation for the current behavior, its better to fix this redundancy which is being done in #24162
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
Concept NACK. There's really no good reason to use the same private key for multiple different addresses, is there? |
|
There are good reasons to use the same privkey for multiple different addresses. One of them is unit testing / test vectors for some application that uses addresses (e.g. BIP-322). Edit: besides, all this does is describe how to do it, the functionality itself is already there. |
…addresses via descriptor calls
kallewoof
force-pushed
the
202201-derivefromprivkey
branch
from
704eea8 to
523e51f
Compare
4 participants
…addresses via descriptor calls.
This is not obvious, so deserves some documentation. It might be worth it to also add a 'don't care about checksum' flag to
deriveaddressesto avoid thegetdescriptorinfostep.See #24160, #24162.