p2p: Split network logging into two categories#24247
p2p: Split network logging into two categories#24247anshu-khare-design wants to merge 0 commit intobitcoin:masterfrom
Conversation
There was a problem hiding this comment.
Hi, @anshu-khare-design. Thanks for this. Some points:
- I think you might write a more appropriate commit message (maybe the same as the PR title)
- CI is failing because of
rpc_miscfunctional test:
# Test logging RPC returns the expected number of logging categories.
assert_equal(len(node.logging()), 27)this assertion is failing because with this PR we have one more category, so, in total, 28. You should update this test as well.
|
Cool. Now you should squash the commits. See: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
|
Oops.. I think I did something wrong.. $ git rebase -i HEAD~3 |
|
@anshu-khare-design try this This will close the pull request, it will have 0 commits and you can start fresh in your fork repository Make all the changes in the code, do 1 commit and reopen pull request. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
@prayank23 gave some tips. Feel free to ask for help whenever needed. |
76a854b to
36f8e99
Compare
|
Please don't open new PRs for the same change. (#24273). |
This PR is to resolve issue 20576. It focuses on introducing different levels of net logging. As a starting point, as mentioned in the issue #20576 , it creates separate lower-frequency, important peer-level events (netpeers) from very high-frequency message-level passing (netmessages).