build: Add `show-%` target for multi-line variables and debug info by hebasto · Pull Request #24283 · bitcoin/bitcoin

hebasto · 2022-02-07T09:15:24Z

This PR is a continuation of #17087.

Our depends builds system uses a bunch of variables which values consist of some lines, i.e., multi-line variables.

During debugging it is annoying that print-% is unable to handle such variables:

$ cd depends
$ make print-sqlite_set_vars
/bin/sh: 1: Syntax error: Unterminated quoted string
make: *** [Makefile:5: print-sqlite_set_vars] Error 2

This PR adds show-% target which prints multi-line variable value and its origin and flavor as well:

$ cd depends
$ make show-sqlite_set_vars
- name:   sqlite_set_vars
- origin: file
- flavor: simple
- value, printed from the new line:
sqlite_config_opts=--disable-shared --disable-readline --disable-dynamic-extensions --enable-option-checking
sqlite_config_opts_linux=--with-pic
sqlite_config_opts_freebsd=--with-pic
sqlite_config_opts_netbsd=--with-pic
sqlite_config_opts_openbsd=--with-pic

For connoisseurs suggesting make show-qt_set_vars :)

Other useful examples of usage:

$ make show-CC
- name:   CC
- origin: default
- flavor: recursive
- value, printed from the new line:
cc

$ make show-CC CC=clang
- name:   CC
- origin: command line
- flavor: recursive
- value, printed from the new line:
clang

$ CC=clang make show-CC
- name:   CC
- origin: environment
- flavor: recursive
- value, printed from the new line:
clang

$ make show-host
- name:   host
- origin: file
- flavor: simple
- value, printed from the new line:
x86_64-pc-linux-gnu

Please note that it is unwanted to just modify the print-% rule as it is used in scripts.

laanwj · 2022-02-09T14:09:33Z

Concept ACK. I think this kind of debugging functionality is very useful, especially for complex makefiles such as those used in the depends system.

DrahtBot · 2022-02-11T05:19:00Z

Guix builds

File	commit `eca694a` (master)	commit 37930cc96d774aa585beb0ffd15a968bff3f6296 (master and this pull)
SHA256SUMS.part	`52bb278f472c04ff...`	`ecf6af9fdb2c36c6...`
*-aarch64-linux-gnu-debug.tar.gz	`1ea67072871fb3e9...`	`b94b8141e2f6b497...`
*-aarch64-linux-gnu.tar.gz	`ab7737ea08cce568...`	`e677b2e06b9f3eba...`
*-arm-linux-gnueabihf-debug.tar.gz	`ae6c042bb3938d92...`	`720cc6307f3e4a3a...`
*-arm-linux-gnueabihf.tar.gz	`13c2fd99fa3ff645...`	`ef2dcf56d8ef0f63...`
*-arm64-apple-darwin.tar.gz	`f2af6d80043feda6...`	`df1cd52f10dde100...`
*-osx-unsigned.dmg	`77200c90800d39ed...`	`8a58f09f6560a72b...`
*-osx-unsigned.tar.gz	`9f07da42c43106fb...`	`985359524a727ad0...`
*-osx64.tar.gz	`43d3aee5c66221ba...`	`ff727a0f931924a1...`
*-powerpc64-linux-gnu-debug.tar.gz	`4ba7a36e05279e3b...`	`3cc3cfa73956fd68...`
*-powerpc64-linux-gnu.tar.gz	`882fe0c68aad339a...`	`8c8d14aedfab8046...`
*-powerpc64le-linux-gnu-debug.tar.gz	`d35588fadf892dea...`	`50a7b91e7881b3e3...`
*-powerpc64le-linux-gnu.tar.gz	`19808899c534b9b0...`	`aadb8d614eff760f...`
*-riscv64-linux-gnu-debug.tar.gz	`1693a2d394dccb60...`	`ac140f2b9cd70160...`
*-riscv64-linux-gnu.tar.gz	`27cdc3197b74b915...`	`677c26a94aa694ef...`
*-x86_64-linux-gnu-debug.tar.gz	`0ea261146b90e7dc...`	`5ce6c765b0f9c23a...`
*-x86_64-linux-gnu.tar.gz	`bca2953d8b7fe08a...`	`58a391cb8e9c3204...`
*.tar.gz	`527dddd72b8fb635...`	`b0484d3379dd40b8...`
guix_build.log	`066fdaf5e045c1dc...`	`54a5b2cbea1be9d4...`
guix_build.log.diff		`7fcffb58297acb76...`

laanwj · 2022-04-05T14:01:57Z

Any reason for keeping this in draft status?

DrahtBot · 2022-04-12T03:41:21Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#25964 (build: fix mingw miniupnpc cflags by fanquake)
#21778 (build: LLVM 14 & LLD based macOS toolchain by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

jonatack · 2022-04-12T10:33:10Z

Concept ACK

hebasto · 2022-04-16T17:59:14Z

@laanwj

Any reason for keeping this in draft status?

The wrong output here:

$ make show-sqlite_set_vars
- name:   sqlite_set_vars
- origin: file
- flavor: recursive
- value, printed from the new line:
zeromq_config_opts=--disable-shared --disable-readline --disable-dynamic-extensions --enable-option-checking
zeromq_config_opts_linux=--with-pic
zeromq_config_opts_freebsd=--with-pic
zeromq_config_opts_netbsd=--with-pic
zeromq_config_opts_openbsd=--with-pic

hebasto · 2022-04-16T19:09:54Z

Any reason for keeping this in draft status?

Ready for reviewing now.

@laanwj

Thank you for your reminding.

hebasto · 2022-04-16T19:18:19Z

The PR description has been updated.

jarolrod · 2022-04-19T04:58:55Z

concept ack

laanwj · 2022-06-27T13:39:54Z

depends/packages/bdb.mk

 $(package)_patches=clang_cxx_11.patch

-define $(package)_set_vars
+define $(package)_set_vars :=


Maybe a dumb question, but what does the added := do?

It makes $(package)_set_vars a simply expanded variable which value is defined just after parsing.

hebasto · 2022-07-20T09:34:52Z

Rebased f323829 -> 2d290d8 (pr24283.03 -> pr24283.04).

hebasto · 2022-07-27T13:47:36Z

Rebased 2d290d8 -> 6c18d85 (pr24283.04 -> pr24283.05) due to the conflict with #25697.

This change guarantees that variable values are correct at any time. -BEGIN VERIFY SCRIPT- s() { sed --in-place --expression="s/$1$/$2/g" $(git grep --files-with-matches "$1" "$3"); } s 'define $(package)_set_vars' 'define $(package)_set_vars :=' './depends' -END VERIFY SCRIPT-

hebasto · 2022-08-04T09:16:03Z

Rebased 6c18d85 -> 9d568cc (pr24283.05 -> pr24283.06) due to the conflict with #25633.

achow101 · 2022-10-12T19:04:57Z

Are you still working on this?

hebasto · 2022-10-12T19:09:13Z

Are you still working on this?

I am. However, closing due to the lack of interest from other developers.

hebasto added the Build system label Feb 7, 2022

maflcko added the DrahtBot Guix build requested label Feb 7, 2022

hebasto marked this pull request as draft February 7, 2022 21:46

DrahtBot removed the DrahtBot Guix build requested label Feb 11, 2022

DrahtBot mentioned this pull request Apr 12, 2022

build, qt: Add Wayland support for Linux builds with depends #22708

Closed

hebasto changed the title ~~build: Add print-all-% target for multi-line variables and debug info~~ build: Add show-% target for multi-line variables and debug info Apr 16, 2022

hebasto force-pushed the 220207-print branch from a7211a1 to 9fbe577 Compare April 16, 2022 17:57

hebasto force-pushed the 220207-print branch 3 times, most recently from 584b2bc to f323829 Compare April 16, 2022 18:59

hebasto marked this pull request as ready for review April 16, 2022 19:04

DrahtBot mentioned this pull request Apr 17, 2022

build: LLD based macOS toolchain #21778

Merged

DrahtBot mentioned this pull request Apr 23, 2022

build: Improve depends build system robustness #22552

Closed

DrahtBot mentioned this pull request Jun 24, 2022

build: GCC-12 build improvements #25436

Merged

DrahtBot added the Needs rebase label Jun 27, 2022

laanwj reviewed Jun 27, 2022

View reviewed changes

hebasto force-pushed the 220207-print branch from f323829 to 2d290d8 Compare July 20, 2022 09:33

hebasto requested a review from fanquake July 20, 2022 09:36

DrahtBot removed the Needs rebase label Jul 20, 2022

DrahtBot mentioned this pull request Jul 20, 2022

depends: don't restrict --enable-lto to non-guix cctools #25633

Merged

This was referenced Jul 20, 2022

guix: Use LTO to build releases #25391

Closed

depends: expat 2.4.8 & fix building with -flto #25697

Merged

DrahtBot added the Needs rebase label Jul 27, 2022

hebasto force-pushed the 220207-print branch from 2d290d8 to 6c18d85 Compare July 27, 2022 13:46

DrahtBot removed the Needs rebase label Jul 27, 2022

DrahtBot added the Needs rebase label Aug 4, 2022

hebasto added 2 commits August 4, 2022 10:13

build: Add show-% target for multi-line variables and debug info

9d568cc

hebasto force-pushed the 220207-print branch from 6c18d85 to 9d568cc Compare August 4, 2022 09:14

DrahtBot removed the Needs rebase label Aug 4, 2022

DrahtBot mentioned this pull request Sep 23, 2022

build: fix mingw miniupnpc cflags #25964

Merged

hebasto closed this Oct 12, 2022

bitcoin locked and limited conversation to collaborators Oct 12, 2023

Conversation

hebasto commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Feb 9, 2022

Uh oh!

DrahtBot commented Feb 11, 2022

Guix builds

Uh oh!

laanwj commented Apr 5, 2022

Uh oh!

DrahtBot commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

jonatack commented Apr 12, 2022

Uh oh!

hebasto commented Apr 16, 2022

Uh oh!

hebasto commented Apr 16, 2022

Uh oh!

hebasto commented Apr 16, 2022

Uh oh!

jarolrod commented Apr 19, 2022

Uh oh!

laanwj Jun 27, 2022

Choose a reason for hiding this comment

Uh oh!

hebasto Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jul 20, 2022

Uh oh!

hebasto commented Jul 27, 2022

Uh oh!

hebasto commented Aug 4, 2022

Uh oh!

achow101 commented Oct 12, 2022

Uh oh!

hebasto commented Oct 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hebasto commented Feb 7, 2022 •

edited

Loading

DrahtBot commented Apr 12, 2022 •

edited

Loading