@MarcoFalke

Do you think that the fuzz task timeout is caused by this PR change?

No

This should be combined with the CHECK_RUNTIME_LIB check rather than another enable_fuzz_binary test.

A third refacotring alternative might be to remove it. Then, call AX_CHECK_LINK_FLAG unconditionally?

Updated 4a1e159 -> 7e7ae42 (pr24337.01 -> pr24337.02).

This should be combined with the CHECK_RUNTIME_LIB check rather than another enable_fuzz_binary test.

A third refacotring alternative might be to remove it. Then, call AX_CHECK_LINK_FLAG unconditionally?

Chosen the former suggestion as it assumes minimal diff.

Updated 7e7ae42 -> 8d0683d (pr24337.02 -> pr24337.03): reverted back and rebased.

This should be combined with the CHECK_RUNTIME_LIB check rather than another enable_fuzz_binary test.

Doesn't work. Fails with "multiple definition of `main'" error.

A third refacotring alternative might be to remove it. Then, call AX_CHECK_LINK_FLAG unconditionally?

Doesn't work. The -DPROVIDE_FUZZ_MAIN_FUNCTION macro still defined even configured with --disable-fuzz-binary.

I mean:

if enable_fuzz_binary:
  AX_CHECK_LINK_FLAG
  CHECK_RUNTIME_LIB
fi

I mean:

if enable_fuzz_binary:
  AX_CHECK_LINK_FLAG
  CHECK_RUNTIME_LIB
fi

Thanks! Done: 8d0683d -> 121c4ba (pr24337.03 -> pr24337.04).

I mean:

if enable_fuzz_binary:
  AX_CHECK_LINK_FLAG
  CHECK_RUNTIME_LIB
fi

Thanks! Done: 8d0683d -> 121c4ba (pr24337.03 -> pr24337.04).

Reverted back due to the CI failures.

failures

That's because it incorrectly uses a previously cached, but unrelated result. You can work around that with:

diff --git a/configure.ac b/configure.ac
index b7852ae3b5..efdeb186c3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1300,7 +1300,7 @@ fi
 if test "$enable_fuzz_binary" = "yes"; then
   AC_MSG_CHECKING([whether main function is needed for fuzz binary])
   AX_CHECK_LINK_FLAG(
-    [-fsanitize=$use_sanitizers],
+    [-fsanitize= -fsanitize=$use_sanitizers],
     [AC_MSG_RESULT([no])],
     [AC_MSG_RESULT([yes]); CPPFLAGS="$CPPFLAGS -DPROVIDE_FUZZ_MAIN_FUNCTION"],
     [],

See https://cirrus-ci.com/task/6160465456791552?logs=ci#L2772

checking whether main function is needed for fuzz binary... checking whether the linker accepts -fsanitize=address,integer,undefined... (cached) yes
no

fsanitize=address,integer,undefined... (cached) yes

Yeap, AX_CHECK_LINK_FLAG creates and uses a cached variable ax_cv_check_ldflags_$4_$1.

Updated 8d0683d -> c0a089b (pr24337.03 -> pr24337.05):

• addressed @MarcoFalke's comment

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #23969 (build: remove use of TARGET_OS and BUILD_OS by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Rebased c0a089b -> 3ec7dc7 (pr24337.05 -> pr24337.06).

Updated 3ec7dc7 -> c9c4e6c (pr24337.06 -> pr24337.07, diff):

• addressed @fanquake's comment

Guix builds

Approach ACK c9c4e6c did not review or test 🐤

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Approach ACK c9c4e6cadda85783a005af773a683d44a208bf67 did not review or test 🐤
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUiutAv/UkJoJlQodqTvhH4MJ1Hy/QXpFzWdLaVWy3Uts0sXjd+FX7VfiHVaoikh
TuI0Zf22JJuvywfMWfdn1Dk/FTHsk06asCyADFFEzNzZjq5yOkLp6SrCb/CBbulg
TOhOYMYoLuFl/HoJEdUUlwIPmN6Bf26v0vCrrM7/tuoQhZNFBx84wliriyq44n43
FCs5JwcFI84XuDxsI2evH93qLuLuQ50cjw2XocI3cU3MQjleqEOpuVmjeSU2z40m
sBQb7hpCddtJ4PQe/YKYQNA+VAQ9Wz3jS8cVn2PMkhlQTOK+JzkWQEU/H8dC1TxV
dKGcUG9GQoYGVq6UVpP4J0IdfQq5i++1c5uHnxOEH7M+VcUe4LyeAX820S/v4a0n
ORRc5NicHpV7d1TKK4PRdYWL1egWib8dqhmbRuGRS9dvhyk1guhdvxOWQyBPveJi
XiwxUPIIb/N2gWbJsSEIGqMnN4jE17I3o3jXhdwlHR4MGqlX/DaA5zxGBbPRpTSF
aC8Pv1LA
=qSZS
-----END PGP SIGNATURE-----