rpc: Improve RPC help by explicitly mentioning output types#24339
Merged
maflcko merged 2 commits intobitcoin:masterfrom Feb 21, 2022
Merged
rpc: Improve RPC help by explicitly mentioning output types#24339maflcko merged 2 commits intobitcoin:masterfrom
maflcko merged 2 commits intobitcoin:masterfrom
Conversation
…pc/util.{h|cpp}`
kiminuo
changed the title
Contributor
Author
|
cc @laanwj given he said #23320 (comment). |
Member
|
Concept ACK Edit: diff: --- /tmp/getblock.1 2022-02-15 13:33:21.436527762 +0100
+++ /tmp/getblock.2 2022-02-15 13:48:38.017920912 +0100
@@ -66,7 +66,7 @@
"asm" : "str", (string) The asm
"hex" : "str", (string) The hex
"address" : "str", (string, optional) The Bitcoin address (only if a well-defined address exists)
- "type" : "str" (string) The type, eg 'pubkeyhash'
+ "type" : "str" (string) The type (nonstandard, pubkey, pubkeyhash, scripthash, multisig, nulldata, witness_v0_scripthash, witness_v0_keyhash, witness_v1_taproot, witness_unknown)
}
}
}, |
|
Concept ACK Seems like an improvement to display all the output types in the RPC help rather than just the |
Contributor
Author
|
Does it make sense to you to use Is the output OK? Or are possibly any output types that you would NOT show? |
luke-jr
approved these changes
Feb 18, 2022
Member
luke-jr
left a comment
luke-jr
left a comment
There was a problem hiding this comment.
utACK 78d9227ced0442c10249a08ba86386f7b3d2755a
Contributor
|
Concept ACK |
kiminuo
force-pushed
the
feature/2022-02-output-types
branch
from
78d9227 to
c9ca3e8
Compare
kristapsk
approved these changes
Feb 21, 2022
Contributor
kristapsk
left a comment
kristapsk
left a comment
There was a problem hiding this comment.
ACK c9ca3e8bab76da8ab20c362c8cd541443e2e8d77
prusnak
approved these changes
Feb 21, 2022
Contributor
prusnak
left a comment
prusnak
left a comment
There was a problem hiding this comment.
Approach ACK c9ca3e8bab76da8ab20c362c8cd541443e2e8d77
maflcko
reviewed
Feb 21, 2022
kiminuo
force-pushed
the
feature/2022-02-output-types
branch
from
c9ca3e8 to
c821ab8
Compare
kristapsk
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to replicate
bitcoin/src/rpc/rawtransaction.cpp
Line 547 in 0ccf9b2
I created this PR as a follow-up to the idea mentioned here #23320 (comment) (resolved).