User-facing content and codebase doc fixups from transifex translator feedback by jonatack · Pull Request #24367 · bitcoin/bitcoin

jonatack · 2022-02-17T12:45:39Z

jonatack · 2022-02-17T12:47:04Z

(When to use cannot vs can not: https://writingexplained.org/cannot-or-can-not-difference. The cases when "can not" would be used are somewhat rare and not encountered here.)

ghost · 2022-02-17T12:57:56Z

(When to use cannot vs can not: https://writingexplained.org/cannot-or-can-not-difference. The cases when "can not" would be used are somewhat rare and not encountered here.)

Based on this link: https://english.stackexchange.com/questions/4510/why-is-cannot-spelled-as-one-word both look okay to me.

Overall I have no issues with the changes made in this PR.

ACK 4982b32

hebasto

Concept ACK.

doc/build-unix.md

hebasto

ACK 4982b329b7d4f0e0343b0fa23b19d1a538eca4d6

jonatack · 2022-02-17T13:16:13Z

(TBH I'd noticed most of this diff before but thought they were too pedantic to propose changing. To my mind this is more to avoid spending further time on it.)

hebasto · 2022-02-17T13:18:29Z

(TBH I'd noticed most of this diff before but thought they were too pedantic to propose changing. To my mind this is more to avoid spending further time on it.)

Translators forms a good focus-group for Bitcoin Core UI testing :)

w0xlt

ACK 4982b32

luke-jr

I think the current strings are better, and don't see rationale for changing them (exception ACK'd)

luke-jr · 2022-02-19T00:24:37Z

src/wallet/spend.cpp

jonatack · 2022-02-20T17:10:47Z

I think the current strings are better, and don't see rationale for changing them (exception ACK'd)

That leaves

"free space available", which I agree may not bother native speakers (it doesn't bother me, at least) but I can see why it may appear redundant to non-natives / English-as-a-second language speakers (as seen in the referenced issue in the PR description), so we may as well avoid the issue coming up
"can not", for which there are explanations and links above

jonatack · 2022-02-21T13:40:52Z

Summary: this has 3 ACKs from @prayank23, @hebasto and @w0xlt

laanwj · 2022-02-21T14:46:04Z

Code review ACK 4982b32
Code review re-ACK 4874269
~~But would prefer the change in build-unix.md to be reverted, it's better to quote error messages verbatim even if they contain typos.~~ (addressed)

jonatack · 2022-02-21T18:12:42Z

Updated per review feedback to leave the error example as-is in doc/build-unix.md. Thanks!

hebasto

re-ACK 4874269, only suggested change since my previous review.

maflcko · 2022-02-22T12:12:24Z

src/wallet/spend.cpp

    else if ((unsigned int)nChangePosInOut > txNew.vout.size())
    {
-        error = _("Change index out of range");
+        error = _("Transaction change output index out of range");


Is there any value in translating this? I mean it is not possible to set the change position via the GUI, no?

… transi…

User-facing content fixups from transifex translator feedback

e670edd

jonatack mentioned this pull request Feb 17, 2022

Transifex translators feedback #24366

Closed

3 tasks

jonatack changed the title ~~User-facing content fixups from transifex translator feedback~~ User-facing content and codebase doc fixups from transifex translator feedback Feb 17, 2022

hebasto reviewed Feb 17, 2022

View reviewed changes

doc/build-unix.md Outdated Show resolved Hide resolved

hebasto approved these changes Feb 17, 2022

View reviewed changes

DrahtBot added GUI P2P RPC/REST/ZMQ Scripts and tools UTXO Db and Indexes Validation Wallet labels Feb 17, 2022

hebasto mentioned this pull request Feb 18, 2022

qt: Update translation source file #24377

Merged

w0xlt approved these changes Feb 18, 2022

View reviewed changes

luke-jr reviewed Feb 19, 2022

View reviewed changes

src/wallet/spend.cpp Outdated

Copy link

Member

luke-jr Feb 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

laanwj removed Wallet UTXO Db and Indexes RPC/REST/ZMQ P2P Validation Scripts and tools labels Feb 21, 2022

Replace "can not" with "cannot" in docs, user messages, and tests

4874269

jonatack force-pushed the fixes-based-on-transifex-translator-feedback branch from 4982b32 to 4874269 Compare February 21, 2022 18:08

hebasto approved these changes Feb 21, 2022

View reviewed changes

laanwj merged commit 8add59d into bitcoin:master Feb 22, 2022

maflcko reviewed Feb 22, 2022

View reviewed changes

jonatack deleted the fixes-based-on-transifex-translator-feedback branch February 22, 2022 15:25

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 22, 2022

Merge bitcoin#24367: User-facing content and codebase doc fixups from…

88bd0e3

… transi…

bitcoin locked and limited conversation to collaborators Feb 22, 2023

Conversation

jonatack commented Feb 17, 2022

Uh oh!

jonatack commented Feb 17, 2022

Uh oh!

ghost commented Feb 17, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack commented Feb 17, 2022

Uh oh!

hebasto commented Feb 17, 2022

Uh oh!

w0xlt left a comment

Choose a reason for hiding this comment

Uh oh!

luke-jr left a comment

Choose a reason for hiding this comment

Uh oh!

luke-jr Feb 19, 2022

Choose a reason for hiding this comment

Uh oh!

jonatack commented Feb 20, 2022

Uh oh!

jonatack commented Feb 21, 2022

Uh oh!

laanwj commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack commented Feb 21, 2022

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

maflcko Feb 22, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ghost commented Feb 17, 2022 •

edited by ghost

Loading

laanwj commented Feb 21, 2022 •

edited

Loading