blockman: Properly guard blockfile members#24456
blockman: Properly guard blockfile members#24456dongcarl wants to merge 3 commits intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
dongcarl
force-pushed
the
2022-02-kirby-p4
branch
from
422f1f3 to
1b95be4
Compare
|
Pushed 422f1f37e6a89a36bc09d5898f08e5cf7263ac81 -> 1b95be4ebe3eeea404cb44f35f31ce6d58e2bbe8
|
dongcarl
force-pushed
the
2022-02-kirby-p4
branch
from
1b95be4 to
f097cc3
Compare
|
Pushed 1b95be4ebe3eeea404cb44f35f31ce6d58e2bbe8 -> f097cc3b23dede7d3afec9a6bea48e76f9bb4938 |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Add GUARDED_BY(cs_LastBlockFile) annotations to:
- m_blockfile_info
- m_last_blockfile
- m_check_for_pruning
Add locking annotations as appropriate.
[META] Some of these LOCK annotations will be turned into a
AssertLockHeld+EXCLUSIVE_LOCKS_REQUIRED combo in the next commit
It is only used in CChainState::PreciousBlock with ::cs_main locked.
|
Pushed f097cc3b23dede7d3afec9a6bea48e76f9bb4938 -> d69bca1
|
|
Not going to nurse this PR anymore, feel free to take for yourself! |
3 participants
Logically a rebase of: #15191
Based on and split off from: #22564
Last commit arose out of review: #22564 (comment)