Skip to content

doc: update multisig-tutorial.md to descriptor wallet by default#24519

Merged
achow101 merged 1 commit intobitcoin:masterfrom
jonatack:multisig-tutorial-update
Mar 16, 2022
Merged

doc: update multisig-tutorial.md to descriptor wallet by default#24519
achow101 merged 1 commit intobitcoin:masterfrom
jonatack:multisig-tutorial-update

Conversation

@jonatack
Copy link
Member

@jonatack jonatack commented Mar 10, 2022

Follow-up to #24281 and #24281 (comment). The default wallet type was changed to descriptor wallets in #23002.

@fanquake fanquake added the Docs label Mar 10, 2022
laanwj
laanwj reviewed Mar 10, 2022
View reviewed changes
@laanwj
Copy link
Member

laanwj commented Mar 10, 2022

Concept ACK on removing descriptors=true.

@jonatack jonatack force-pushed the multisig-tutorial-update branch from 4f0573c to 5347c97 Compare March 10, 2022 11:51
@laanwj
Copy link
Member

laanwj commented Mar 10, 2022

Right. In general there is IMO no reason to prefer unnamed to named syntax, or the other way around. Whatever is clearer. In this case, it's named.

ACK 5347c97

theStack
theStack approved these changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@theStack theStack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept and code-review ACK 5347c97

Slightly related, but certainly not high priority: there are also numerous createwallet RPC calls with descriptors=True in functional tests that where the explicit parameter could also be omitted on the long-term.

@michaelfolkson
Copy link

michaelfolkson commented Mar 13, 2022

ACK 5347c97

Improved docs with no need to specify a descriptor wallet given it is default.

there are also numerous createwallet RPC calls with descriptors=True in functional tests that where the explicit parameter could also be omitted on the long-term

Not in scope for this PR but could be omitted in additional PRs now right? Doesn't need to be long term?

@theStack theStack mentioned this pull request Mar 13, 2022
Closed
@theStack
Copy link
Contributor

theStack commented Mar 13, 2022

there are also numerous createwallet RPC calls with descriptors=True in functional tests that where the explicit parameter could also be omitted on the long-term

Not in scope for this PR but could be omitted in additional PRs now right? Doesn't need to be long term?

Sure, it can be done immediately. I think this task makes a perfect candidate for a good first issue: #24550

@jonatack
Copy link
Member Author

jonatack commented Mar 16, 2022

@achow101 this seems RFM

@achow101
Copy link
Member

achow101 commented Mar 16, 2022

ACK 5347c97

@achow101 achow101 merged commit 114754a into bitcoin:master Mar 16, 2022
@jonatack jonatack deleted the multisig-tutorial-update branch March 16, 2022 20:27
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 16, 2022
@achow101
Merge bitcoin#24519: doc: update multisig-tutorial.md to descriptor w…
3163d06 
…allet b…
@bitcoin bitcoin locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@laanwj laanwj laanwj left review comments

+1 more reviewer

@theStack theStack theStack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jonatack @laanwj @michaelfolkson @theStack @achow101 @fanquake