doc: Clarify that CheckSequenceLocksAtTip is a validation function#24564
Merged
glozow merged 1 commit intobitcoin:masterfrom Aug 9, 2022
Hidden character warning
The head ref may contain hidden characters: "2203-docVal-\ud83c\udf61"
Merged
doc: Clarify that CheckSequenceLocksAtTip is a validation function#24564glozow merged 1 commit intobitcoin:masterfrom
glozow merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
Could say "mempool validation helper functions" if your intent is to convey that these are only used for validating transactions being {,re-}added to the mempool. |
Member
Author
|
An alternative follow-up suggested to use check the sequence locks before including a tx in a template. (#24080 (comment)) As that requires reading the utxo set, I am not sure about the performance impact. So I'll leave it for a follow-up. |
Member
Author
|
Thx, done. |
Member
|
Concept NACK: Block template creation IS mere policy. |
Member
Author
|
Maybe we need a separate word to describe block templates that are consensus invalid? It doesn't seem policy nor consensus, so I picked "validation". |
Contributor
|
ACK fa86710 - looks fine to me |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 9, 2022
…alidation function fa86710 Clarify that CheckSequenceLocksAtTip is a validation function (MarcoFalke) Pull request description: It has been pointed out that a bug in this function can prevent block template creation. ( bitcoin#24080 (comment) ) So it seems that the scope of this function is more than "policy". Rename it back to "validation", to partially revert commit fa4e30b. ACKs for top commit: ajtowns: ACK fa86710 - looks fine to me glozow: ACK fa86710 Tree-SHA512: 2e0df8c70df4cbea857977f140a8616cfa7505e74df66c9c9fbcf184670ce3ce7567183c3f76e6f3fe8ca6de0e065b9babde6352d6cb495e71ea077ddedbc3f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been pointed out that a bug in this function can prevent block template creation. ( #24080 (comment) ) So it seems that the scope of this function is more than "policy". Rename it back to "validation", to partially revert commit fa4e30b.