refactor: Move mempool RPCs to rpc/mempool#24656
Hidden character warning
Conversation
Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
maflcko
force-pushed
the
2203-more-mempool-
branch
from
cf50a75 to
fac5a51
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
Concept ACK
- The static keyword is used appropriately in
rpc/mempool.cppfile. I checked for any other instances where a static keyword could be used and found none. - The moved code looks good to me. I was able to verify the move-only changes in the second commit successfully.
- I was able to compile the PR successfully on Ubuntu 20.04
| {"rawtransactions", &sendrawtransaction}, | ||
| {"rawtransactions", &testmempoolaccept}, |
There was a problem hiding this comment.
nit:
I would suggest putting these two lines after the rest of the blockchain category functions to match the proper lexicographical ordering.
There was a problem hiding this comment.
I am expecting that everything will move to a new mempool category later, so I am leaving as-is for now.
There was a problem hiding this comment.
I think that's acceptable reasoning.
Other than this, I can't find any blockers for this PR, and hence I think it can be merged.
ACK fac5a51
4 participants
This moves the remaining mempool RPCs to
rpc/mempool. Previously all mempool RPCs from theblockchaincategory have been moved. This patch moves the ones from therawtransactionscategory.In the future, as a follow-up to this refactoring patch, it could be considered whether a new
mempoolcategory should be introduced.Beside a clearer code organization, this pull request should also reduce the compile time and space of the
rawtransactions.cppfile.