doc: document clang tidy named args#24665
Merged
fanquake merged 2 commits intobitcoin:masterfrom Mar 25, 2022
Merged
Conversation
maflcko
reviewed
Mar 25, 2022
| return AddressPosition(/*tried_in=*/false, | ||
| /*multiplicity_in=*/addr_info->nRefCount, | ||
| /*bucket_in=*/bucket, | ||
| /*position_in=*/addr_info->GetBucketPosition(nKey, true, bucket)); |
Member
There was a problem hiding this comment.
unrelated comment:
If msvc was less crappy, we could use designated initializers to enforce named args in constructors without clang-tidy, see #24531
glozow
reviewed
Mar 25, 2022
Member
glozow
left a comment
glozow
left a comment
There was a problem hiding this comment.
Concept ACK, would be nice to be able to point to developer notes when someone asks why I'm formatting arg names this way. The instructions look correct. Were you planning on fixing all of the clang-tidy violations or just these in addrman.cpp?
Member
Author
Member
Ok gotchu makes sense |
glozow
reviewed
Mar 25, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 2, 2022
7e22d80 addrman: fix incorrect named args (fanquake) 67f654e doc: Document clang-tidy in dev notes (MarcoFalke) Pull request description: The documentation, and a single commit extracted from bitcoin#24661. Motivation: > Incorrect named args are source of bugs, like bitcoin#22979. > To allow them being checked by clang-tidy, use a format it can understand. ACKs for top commit: glozow: ACK 7e22d80 Tree-SHA512: 4037fcea59fdf583b171bce7ad350299fe5f9feb3c398413432168f3b9a185e51884d5b30e4b4ab9c6c5bb896c178cfaee1d78d5b4f0034cd70121c9ea4184b7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation, and a single commit extracted from #24661.
Motivation: