test: move-only: Move all generate* tests to a single file#24670
Merged
maflcko merged 1 commit intobitcoin:masterfrom Mar 25, 2022
Hidden character warning
The head ref may contain hidden characters: "2203-test-gen-\ud83c\udffb"
Merged
test: move-only: Move all generate* tests to a single file#24670maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Can be reviewed with --color-moved=dimmed-zebra
Contributor
|
Concept ACK |
Contributor
|
Strong concept ACK |
glozow
reviewed
Mar 25, 2022
Comment on lines
-29
to
-30
| # Checking mining to an address without a wallet. Generating to a valid address should succeed | ||
| # but generating to an invalid address will fail. |
Member
There was a problem hiding this comment.
Review note - this comment has been removed. Imo it's fine since all of the generate tests are with wallet disabled, so the comment doesn't add much value.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 2, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems a bit overkill to spread tests for the
generate*methods over several files. Combining them into a single file has also a nice side-effect of requiring less node (re)starts, which are expensive in valgrind.