build: remove unneeded configure $*val setting#24671
build: remove unneeded configure $*val setting#24671fanquake wants to merge 29 commits intobitcoin:masterfrom
Conversation
|
The automatic setting works only for variables |
😅 Right. I guess we try should clean these up as well; given we currently use a mix of everything throughout configure.. Will update the changes. |
4ef6189 to
9c260d3
Compare
Have done this now. The changes are too granular as-is, and can be split-out / squashed down, but this should better reflect what we want to accomplish. |
|
ACK, tested that {enable,disable}-usdt still works
|
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
9c260d3 to
92c9d75
Compare
real-or-random
left a comment
There was a problem hiding this comment.
I guess it's clear from the context but:
Concept ACK
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
Concept and light code review ACK 92c9d75 |
|
May follow up with some related changes later on. |
Setting these values has been redundant since autoconf ~2.60, and we
require 2.69. Should not change behaviour. Includes minor formatting
improvements.
secp256k1 also recently made the same change:
bitcoin-core/secp256k1#1079.