[WIP] [kernelheaders 1/n] Cleave LevelDB headers from our header tree#24676
Closed
dongcarl wants to merge 18 commits intobitcoin:masterfrom
Closed
[WIP] [kernelheaders 1/n] Cleave LevelDB headers from our header tree#24676dongcarl wants to merge 18 commits intobitcoin:masterfrom
dongcarl wants to merge 18 commits intobitcoin:masterfrom
Conversation
Remove need to ship leveldb/write_batch.h
dongcarl
force-pushed
the
2022-03-kernelheaders-dbwrapper
branch
from
cf1701a to
47ccacd
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 28, 2022
Member
|
Concept ACK. |
This was referenced Apr 8, 2022
This was referenced Apr 19, 2022
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Contributor
Author
|
Closing, @TheCharlatan will follow up with a PR that's simpler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not based on anything other than
master.We
#includeLevelDB headers indbwrapper.h, which means that anything that#include's or transitively#include'sdbwrapper.hwill also pull in the LevelDB headers:bitcoin/src/dbwrapper.h
Lines 16 to 17 in 2f0f056
This PR's changes allow us to remove these LevelDB header
#include's indbwrapper.hand have them be indbwrapper.cppinstead. We achieve this mainly by:doFoo's) to:LevelDB-specific code out of the header,LevelDB-specific member variables out of the headerCoincidentally, this PR also makes obfuscation an implementation detail of the database, as described in this code comment:
bitcoin/src/dbwrapper.h
Lines 39 to 42 in 2f0f056