test: Fix intermittent test failure in wallet_listreceivedby.py#24739
Merged
maflcko merged 1 commit intobitcoin:masterfrom Apr 27, 2022
Hidden character warning
The head ref may contain hidden characters: "2204-test-fail-\ud83c\udf70"
Merged
test: Fix intermittent test failure in wallet_listreceivedby.py#24739maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
mjdietzx
reviewed
Apr 4, 2022
Contributor
mjdietzx
left a comment
mjdietzx
left a comment
There was a problem hiding this comment.
Concept ACK, I noticed this error on a recent CI run for one of my PRs
| address = self.nodes[0].getnewaddress(label) | ||
|
|
||
| reward = Decimal("25") | ||
| self.generatetoaddress(self.nodes[0], 1, address, sync_fun=self.no_op) |
Contributor
There was a problem hiding this comment.
What was the purpose of this in the first place? Was there any reason to have this?
Member
Author
There was a problem hiding this comment.
No idea. I think it was added in b569675. It is only needed for the last call to generate IIUC.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 29, 2022
…streceivedby.py fa1f6df test: Fix intermittent test failure in wallet_listreceivedby.py (MarcoFalke) Pull request description: * Remove not needed "Generate block to get out of IBD" * Sync blocks where possible to avoid incoming blocks on the p2p `msghand` thread while blocks are mined in the RPC thread. See bitcoin#24730 for discussion. Top commit has no ACKs. Tree-SHA512: eca0242e7793886535555fec62f7acd4c0955bf26fab78725b4fe53f84f0b118cb12c9ee35627503fc68b83c3a228842e861fab89aab1226e08e18596357aaae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msghandthread while blocks are mined in the RPC thread. See Race in generatetoaddress? #24730 for discussion.