refactor: Prepare for moving ArgsManager out of util/system#24811
Closed
Empact wants to merge 10 commits intobitcoin:masterfrom
Closed
refactor: Prepare for moving ArgsManager out of util/system#24811Empact wants to merge 10 commits intobitcoin:masterfrom
Empact wants to merge 10 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 10, 2022
Empact
force-pushed
the
2022-03-util-args-manager-prep
branch
from
024e035 to
5e1d52f
Compare
This changes the wallet tests to rely on BasicTestingSetup#m_args rather than gArgs, which seems more appropriate.
… not gArgs In ArgsManager::ReadConfigFiles, we're operating on an ArgsManager - modifying gArgs is incongruous.
Empact
force-pushed
the
2022-03-util-args-manager-prep
branch
from
5e1d52f to
3b8999a
Compare
These were introduced in bitcoin#22950, but they're not used in the header, rather equivalent includes in addrman.cpp do the work.
This file is not required for the dbwrapper interfaces provided, but several other files were getting their necessary includes indirectly via this header. Removing results in more minimal includes throughout.
This is the more minimal include, and the only used therein.
This was referenced Apr 23, 2022
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Contributor
Author
|
Going to rework given inattention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comprises the preparation commits for #24455, which are relatively succinct, for easier review.