test: fix connman UB by calling derived constructor#24841
Merged
maflcko merged 1 commit intobitcoin:masterfrom Apr 16, 2022
Merged
test: fix connman UB by calling derived constructor#24841maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
Author
|
I have kept the order of included header files since |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
include lines are unlikely to be touched for other reasons, unless the included file is renamed, so personally I think it is fine to sort them when one of the include lines of the file is touched |
chinggg
force-pushed
the
fix-test-connman-ub
branch
2 times, most recently
from
89a0a29 to
07624e0
Compare
chinggg
force-pushed
the
fix-test-connman-ub
branch
from
07624e0 to
c848a45
Compare
joshuadbryant1985
approved these changes
Apr 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully closes #24373 by calling
ConnmanTestMsgtest-constructor to avoid undefined behavior in process_message.cpp after castingg_setup->m_node.connman.