lint: Convert lint-include-guards.sh to Python#24902
Merged
laanwj merged 1 commit intobitcoin:masterfrom Apr 25, 2022
Merged
Conversation
Contributor
|
Concept ACK Note that there is currently a linter error in the CI: |
brunoerg
reviewed
Apr 18, 2022
test/lint/lint-include-guards.py
Outdated
Contributor
There was a problem hiding this comment.
I prefer to open files using with, it ensures that the file will be closed at the end of the operation.
Contributor
|
I tested ea3e7abc45730e7a6eb1e840c6fa40780b3dee2f by commenting out the include guard in Before ( After ( If I delete (rather than comment out) the include guard, then it prints the correct message. |
Specify encoding when reading header files, add docstring Update test/lint/lint-include-guards.py include guard count logic Co-authored-by: Kevin Musgrave <[email protected]> Update test/lint/lint-include-guards.py by removing whitespace
3f9f09f to
d5fdec5
Compare
Contributor
|
Tested ACK d5fdec5 Outputs and exit codes match. Example: |
Member
|
Code review ACK d5fdec5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue 24783. Converted lint-include-guards.sh to python.