refactor: update CBlockIndex::nChainTx to be uint64_t#24912
Closed
mruddy wants to merge 1 commit intobitcoin:masterfrom
Closed
refactor: update CBlockIndex::nChainTx to be uint64_t#24912mruddy wants to merge 1 commit intobitcoin:masterfrom
mruddy wants to merge 1 commit intobitcoin:masterfrom
Conversation
There was a comment with this data member: "Change to 64-bit type before 2024 (assuming worst case of 60 byte transactions)." As of when this PR was created, there were only around 750,000,000 transactions in the best chain. I went through all the references to this member and made updates to make the data types line up better where there were differences.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 20, 2022
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Contributor
Author
|
closing since there appears to be no interest in this set of changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a comment with the
CBlockIndex::nChainTxdata member:"Change to 64-bit type before 2024 (assuming worst case of 60 byte transactions)."
As of when this PR was created, there were only around 750,000,000 transactions in the main best chain. That's only in the ballpark of 20% of the range of a 32-bit unsigned int. So, you might think that this is early. But, since I was looking up the references and already doing most of the work, I figured that I'd propose it now. In the least this commit resolves and removes a comment that might otherwise scare more people into doing the same research that I did, thus saving people time.
I went through all the references to this member and made updates to make the data types line up better where there were differences.
I also removed a small amount of dead code from SnapshotMetadata, see (#21681 (comment)).