Remove not needed clang-format off comments#24959
Merged
laanwj merged 1 commit intobitcoin:masterfrom Apr 26, 2022
Hidden character warning
The head ref may contain hidden characters: "2204-no-format-off-\ud83d\udd1d"
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 25, 2022
maflcko
force-pushed
the
2204-no-format-off-
branch
from
fa1ca34 to
faa9392
Compare
Can be reviewed with --word-diff-regex=. --ignore-all-space
maflcko
force-pushed
the
2204-no-format-off-
branch
from
faa9392 to
fa870e3
Compare
This was referenced Apr 25, 2022
Closed
Member
Author
|
Force pushed to remove an empty line |
This was referenced Apr 26, 2022
fanquake
approved these changes
Apr 26, 2022
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems odd to disable clang-format and force manual formatting when there is no need for it. So remove the clang-format comments and other unneeded comments.
Can be reviewed with
--word-diff-regex=. --ignore-all-spaceLooks like this was initially added in commit d9d7957 to accommodate a linter that has since been removed and replaced by a functional test.