Remove unused SetTip(nullptr) code#25023
Merged
fanquake merged 1 commit intobitcoin:masterfrom Aug 4, 2022
Hidden character warning
The head ref may contain hidden characters: "2204-rem-nullptr-\ud83d\udc6f"
Merged
Conversation
|
ACK faa7a1e Testing: IBD against Signet |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
force-pushed
the
2204-rem-nullptr-
branch
from
faa7a1e to
faf57a6
Compare
ryanofsky
approved these changes
Aug 2, 2022
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Code review ACK faf57a6898590cecfbb918d73abbf2c100206b8e
maflcko
force-pushed
the
2204-rem-nullptr-
branch
from
faf57a6 to
faab8dc
Compare
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 4, 2022
faab8dc Remove unused SetTip(nullptr) code (MacroFake) Pull request description: Now that this path is no longer used after commit b51e60f, we can remove it. Future code should reset `CChain` by simply discarding it and constructing a fresh one. ACKs for top commit: ryanofsky: Code review ACK faab8dc. Just moved an assert statement since last review Tree-SHA512: 7dc273b11133d85d32ca2a69c0c7c07b39cdd338141ef5b51496e7de334a809864d5459eb95535497866c8b1e468aae84ed8f91b543041e6ee20130d5622874e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that this path is no longer used after commit b51e60f, we can remove it.
Future code should reset
CChainby simply discarding it and constructing a fresh one.