tidy: use modernize-use-raw-string-literal#25110
Closed
fanquake wants to merge 2 commits intobitcoin:masterfrom
Closed
tidy: use modernize-use-raw-string-literal#25110fanquake wants to merge 2 commits intobitcoin:masterfrom
fanquake wants to merge 2 commits intobitcoin:masterfrom
Conversation
Contributor
|
Just my opinion, but using |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fanquake
force-pushed
the
modernize_use_raw_string_literal
branch
from
f22f5a4 to
3938312
Compare
This was referenced May 12, 2022
The motivation is to replace barely (human) parse-able code like:
HelpExampleCli("createrawtransaction", "\"[{\\\"txid\\\" : \\\"mytxid\\\",\\\"vout\\\":0}]\" \"{\\\"myaddress\\\":0.01}\"")
with code like:
HelpExampleCli("createrawtransaction", R"("[{\"txid\" : \"mytxid\",\"vout\":0}]" "{\"myaddress\":0.01}")")
fanquake
force-pushed
the
modernize_use_raw_string_literal
branch
from
3938312 to
39c83aa
Compare
This was referenced May 23, 2022
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and turn on
modernize-raw-string-literal. See https://clang.llvm.org/extra/clang-tidy/checks/modernize-raw-string-literal.html. This is a bit noisy, but I think ultimately worth it.The motivation is to replace barely-(human)-parseable code like:
with more-readable code like:
while keeping the same output. i.e:
Note that we already sporadically use raw string literals in the code base.