test: add coverage for unknown network in -onlynet#25173
Merged
maflcko merged 1 commit intobitcoin:masterfrom May 20, 2022
Merged
test: add coverage for unknown network in -onlynet#25173maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
Concept ACK, this case looks to be untested. |
jonatack
reviewed
May 19, 2022
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK e9d32dd8dd3c1a2cc42603a792638afe3e170482
brunoerg
force-pushed
the
2022-05-unknown-onlynet
branch
from
e9d32dd to
055d94d
Compare
Member
|
rACK 055d94d |
Member
|
Post-merge re-ACK |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 28, 2022
055d94d test: add coverage for unknown network in -onlynet (brunoerg) Pull request description: This PR adds test coverage for the following init error by passing an unknown network in -onlynet https://github.com/bitcoin/bitcoin/blob/0de36941eca1bff91420dd878eb097db2b1a596c/src/init.cpp#L1311 ACKs for top commit: MarcoFalke: rACK 055d94d Tree-SHA512: 01bbb297afff371f6345889fa04117ff195b68f0bbf934878ba446049791fdbd7d2ce119ee4f9b3616cc0a81330d7055507dc81151acf68532c077f3575258e9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for the following init error by passing an unknown network in -onlynet
bitcoin/src/init.cpp
Line 1311 in 0de3694