Revert "build: more robustly check for fcf-protection support"#25246
Merged
maflcko merged 1 commit intobitcoin:masterfrom May 31, 2022
Merged
Revert "build: more robustly check for fcf-protection support"#25246maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
ACK 460854c1eba7a509327d17fd995b27d9cc8ad5f6 makes sense to revert this workaround. |
hebasto
approved these changes
May 30, 2022
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK 460854c1eba7a509327d17fd995b27d9cc8ad5f6
We no-longer support Clang 7 (bitcoin#24164). This reverts commit e9189a7.
fanquake
force-pushed
the
remove_clang_7_note
branch
from
460854c to
a7973bf
Compare
hebasto
approved these changes
May 31, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 31, 2022
…ction support" a7973bf Revert "build: more robustly check for fcf-protection support" (fanquake) Pull request description: We no-longer support Clang 7 (bitcoin#24164). Introduced in bitcoin#20720. This reverts commit e9189a7. ACKs for top commit: hebasto: re-ACK a7973bf Tree-SHA512: 82559637f21a97434ab29f908ebda1aada08b0786cbbf0b4d11085241942314c3f04261a624c5cd2cb3c94c99046b56626830da6b9775981ab4ba10d5979f998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no-longer support Clang 7 (#24164). Introduced in #20720.
This reverts commit e9189a7.