Add AutoFile without ser-type and ser-version and use it where possible#25285
Hidden character warning
Add AutoFile without ser-type and ser-version and use it where possible#25285fanquake merged 2 commits intobitcoin:masterfrom
Conversation
|
Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
The moved parts can be reviewed with "--color-moved=dimmed-zebra". The one-char changes can be reviewed with "--word-diff-regex=.".
|
Code review ACK facc2fa However, I am not entirely happy about the naming of |
|
|
OK, if it's going away soon™ i have no problem with this. There's something to be said for an intermediate rename, but also there's drawbacks in generating a bigger diff. I just imagined it's pretty frustrating for developers to have similarly named classes with slightly different behavior, it's not something to keep on the long run (it reminds me of the situation in net classes naming |
4 participants
This was done in the context of #25284 , but I think it also makes sense standalone.
The basic idea is that serialization type should not be initialized when it is not needed. Same for the serialization version.
So do this here for
AutoFile.CAutoFileremains in places where it is not yet possible.